8000 Decline the rest, and reopen · Issue #40 · kiran-brahma/writing-tool · GitHub
[go: up one dir, main page]

Skip to content

Decline the rest, and reopen #40

Closed

Description

@kiran-brahma

Parent

#34 — the Obelus v1.2 spec (docs/specs/obelus-v1.2.md). Covers stories 179–182.

Blocked by #35 — the rail restructures FindingsSidebar.

This closes §5.3 of docs/llm-writing-method-audit.md, the last unimplemented recommendation from
that audit.

What to build

The source method's closing move is a writer declining advice. Obelus makes declining one Finding a
single keystroke and declining a whole category — twenty hedges used on purpose — twenty keystrokes.

Two halves, shipped together:

Decline the rest of a Pass. Offered per Pass only — not per Band, not for the whole queue. A
whole-queue decline is dismissing the tool, which the Writer can already do by not running it. Every
Finding it touches is written individually with declineReason: "advice", so they stay declined on
the next Run exactly as a single decline does. "violation" is an assertion that the model breached
the constitution and cannot responsibly be made in bulk — never use it here.

Reopen. writeStatus in src/storage/findings.ts accepts only addressed or declined: there
is no path back to open, so every decline today is one-way, one Finding or twenty. Give it an
open case and give the sidebar a control on rows that have left the queue. The existing invariant
holds — a status that is not declined never keeps a declineReason — so reopening clears it.

These ship in one ticket because a bulk one-way action is what makes the missing path back matter.

Where

  • src/storage/findings.ts — writeStatus gains open; StatusWrite widens.
  • src/core/finding.ts — the pure set of Findings a per-Pass decline touches.
  • src/useDocument.ts — the decline-the-rest and reopen writes.
  • src/editor/FindingsSidebar.tsx — the per-Pass control and the reopen control.

Acceptance criteria

  • Declining the remaining open Findings in one Pass is one action. (story 179)
  • Each is written individually with declineReason: "advice" and stays declined on the next Run.
    (story 180)
  • A Finding that was addressed or declined can be returned to open, and reopening clears
    declineReason. (story 181)
  • The action is offered per Pass and nowhere else — no per-Band and no whole-queue variant.
    (story 182)
  • Declining the rest touches only open Findings in that Pass; it does not disturb ones
    already addressed or declined.
  • No confirmation dialog — reopen is the undo.
  • No new noun: the control reads in the Writer's language and "batch" / "bulk" appear nowhere in
    code, tests, commits or copy.

Verification

Pure tests: the set of Findings a per-Pass decline selects (only open, only that Pass); the status
write for each of the three transitions; and that declineReason is cleared on reopen and absent on
addressed. Assert through the storage entry points against the in-memory IndexedDB.

No DOM layer.

Constitution

Declining needs no justification and stays logged — DESIGN.md §3. Nothing here inserts
model-derived text. Finding status remains exactly three values: open, addressed, declined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ready-for-agentSpec is ready for an agent to implement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0