8000 Fix uzma extension tests by gaoyikeshuer · Pull Request #775 · keycloak/keycloak-quickstarts · GitHub
[go: up one dir, main page]

Skip to content

Fix uzma extension tests - #775

Draft
gaoyikeshuer wants to merge 6 commits into
keycloak:mainfrom
gaoyikeshuer:fix-uzma-extension-tests
Draft

gaoyikeshuer wants to merge 6 commits into
keycloak:mainfrom
gaoyikeshuer:fix-uzma-extension-tests

Conversation

@gaoyikeshuer
Copy link
Copy Markdown

No description provided.

Signed-off-by: uzmamansoor09 <Uzma.Mansoor@ibm.com>

# Conflicts:
#	device/README.md
#	device/src/main/java/org/keycloak/quickstart/DeviceApplication.java
#	device/src/main/java/org/keycloak/quickstart/DeviceController.java
#	device/src/main/java/org/keycloak/quickstart/DeviceFlowService.java
#	device/src/main/resources/templates/device-info.html
#	device/src/test/java/org/keycloak/quickstart/DeviceFlowServiceTest.java
Signed-off-by: uzmamansoor09 <Uzma.Mansoor@ibm.com>
Signed-off-by: uzmamansoor09 <Uzma.Mansoor@ibm.com>
Signed-off-by: uzmamansoor09 <Uzma.Mansoor@ibm.com>
Signed-off-by: uzmamansoor09 <Uzma.Mansoor@ibm.com>
@gaoyikeshuer
gaoyikeshuer force-pushed the fix-uzma-extension-tests branch 6 times, most recently from 6b10359 to 184b350 Compare June 9, 2026 12:40
testPageProviderCancelButton and testTabProviderRevertButton assert the
cancel/revert button (data-testid="cancel"), which was only recently added to
the admin console. The CI nightly is inconsistent around that change, so some
builds render the button and some do not - causing the tests to fail on builds
that genuinely do not have it (verified: the button is absent from the DOM,
only Save is present).

Gate the button checks with Assume.assumeTrue so the tests exercise the button
fully on builds that have it and are skipped (not failed) on builds that do not.

Also keeps the earlier robustness: guarded login in @before, visible-button
waits, and filling the form before checking the button.

Signed-off-by: Yike Gao <yikegao8@gmail.com>
@gaoyikeshuer
gaoyikeshuer force-pushed the fix-uzma-extension-tests branch from 184b350 to 088a6e3 Compare June 9, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0