Repository navigation
Do not strip hash from redirection endpoint - #219
Merged
Merged
Conversation
Contributor
Author
|
@benzitohhh @rmartinc could I ask you to verify this fix works for you? |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the non-standard behavior of stripping hash fragments from redirect URIs in OAuth flows. While the previous implementation followed RFC 6749 section 3.1.2 (which prohibits fragment components in redirect URIs), this change restores hash support to fix regressions for users who rely on redirect URIs containing hash fragments.
Key Changes:
- Removed
stripHash()function calls from redirect URI parameters in both authorization requests and token exchange - Deleted the
stripHash()utility function and its associated RFC compliance comments
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closes keycloak#151 Closes keycloak#205 Signed-off-by: Jon Koops <jonkoops@gmail.com>
jonkoops
force-pushed
the
rm-strip-hash
branch
from
November 19, 2025 11:48
9b0813f to
7b41295
Compare
@jonkoops Perfect - looks great to me. |
Contributor
Author
|
Thanks for the reviews all, merging this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the behavior that strips the hashes from the redirection endpoint URLs. Although this behavior is not standard compliant, it fixes several regressions in instances where users rely on this non-standard behavior.
Closes #151
Closes #205