Repository navigation
KEYCLOAK-19034 HotRod store desing proposal - #321
Merged
Conversation
mhajas
force-pushed
the
KEYCLOAK-19034-Transform-WIP-google-doc-to-community-design-proposal-KEYCLOAK-7301-Zero-downtime-upgrade-of-keycloak-master
branch
from
October 6, 2021 08:46
0c62ec3 to
081b138
Compare
vmuzikar
reviewed
Oct 13, 2021
| to query objects based on field names. It is also possible to create indices to | ||
| speed up queries, more on that later in section [Speeding up queries with | ||
| indices](#speeding-up-queries-with-indices). Infinispan supports queries using | ||
| [Ickle query language](https://infinispan.org/docs/stable/titles/developing/developing.html#creating_ickle_queries-querying). |
Contributor
There was a problem hiding this comment.
Just a nitpick. The link doesn't seem to work. More specifically, doesn't open the docs at the right chapter.
| We use only `clientScopeId` in queries. | ||
|
|
||
| ``` | ||
| FROM nodowntimeupgrade.InfinispanObjectEntity WHERE (clientScopeId == 'desired-value') |
Contributor
There was a problem hiding this comment.
Suggested change
| FROM nodowntimeupgrade.InfinispanObjectEntity WHERE (clientScopeId == 'desired-value') | |
| FROM nodowntimeupgrade.InfinispanObjectEntity WHERE (clientScopeId = 'desired-value') |
| public String name; | ||
| ``` | ||
|
|
||
| - **index** - To index or not to index, that is the switch. |
Contributor
|
@mhajas I probably missed this part but are we going to use cache stores to persist data and survive to server restarts? Also, would this store be our default store and preferrable over the JPA one? How users should choose between one or another? |
Co-authored-by: Martin Kanis <mkanis@redhat.com>
mhajas
force-pushed
the
KEYCLOAK-19034-Transform-WIP-google-doc-to-community-design-proposal-KEYCLOAK-7301-Zero-downtime-upgrade-of-keycloak-master
branch
from
May 19, 2022 08:12
081b138 to
ffaad62
Compare
Contributor
Author
|
@vmuzikar @pedroigor Thank you for the reviews! @hmlnarik Can we merge this or do we need something else? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the proposal of 0-downtime upgradable storage that is using the Infinispan server for storing entities. Keycloak server communicates with the Infinispan server using HotRod protocol.
If you are interested in some code examples, you can find two proof-of-concept implementations.
The first is available in a playground project available in this PR: keycloak/keycloak-playground#11. This Pr contains also some examples of some simple migrations.
And the second, directly in the Keycloak source code, is available in this WIP branch: https://github.com/mhajas/keycloak/tree/KEYCLOAK-19028-Implement-HotRodMapStorage. This implementation does not contain all parts of the proposal yet.
All discussion points should be redirected to the following GH discussion thread: keycloak/keycloak#8571