Repository navigation
Conversation
|
The current Queue has 13 Workflows waiting (some since more than 6 hours) and only 4 in-progress. |
|
Please introduce GH issue and provide analysis of expected savings before filing a PR. According to the previous successful builds, preparation before running each test group takes 2-3 minutes, most of the time is spent in the tests. It seems that this PR expects saving of 8x 2-3 minutes of total running time at the cost of getting the results in longer total time, correct? For example, in the case of wildfly from this run, the results would be available in appx 2 + 43 + 46 + 41 = 132 rather than max(2+43, 2+46, 2+41) = 48 minutes - is this calculation correct? Side note: The Build phase should terminate in not half an hour without and ~ 15 minutes with a cached maven repository. In this PR, it is already over 90 minutes and counting, and there are builds in the queue with build phase running for over 5 hours. Today does not seem to be a representative day for GitHub Actions performance. |
That's exactly the problem, the job got queued for a crazy amount of time(e.g. hours) and the same is happening to most PRs. Thanks for the review and insights @hmlnarik ! |
The job is not queued but running for over 140 minutes. Feel free to check the console to validate |
Confirm, it was a network hiccup.
This PR resolves #9927 that, I believe, is still valid. |
|
@hmlnarik let's discuss on the issue, I move back this PR to draft but I let the CI run to(hopefully) have numbers to compare. |
There was a problem hiding this comment.
I don't see how this helps at all. Sure, it may mean we have more PRs running in parallel, but that doesn't mean the waiting time for completion will be shorter. What I think the result of merging this will be:
- No real difference when there's loads of contention
- Longer total running time when there isn't contention
|
This PR was opened aiming to try this approach out, evaluate the results and iterate, since we are not confident experimenting in this direction I close it. 👍 |
We are currently completely flooding the GH Action runners, this PR should reduce the number of concurrent jobs and, eventually, leave more bandwidth to effectively run the checks for all of the PRs.
cc. @hmlnarik since looks like this matrix was introduced by you.