Repository navigation
LDAP Integration tests fail on JDK-17 - #9980
Merged
Merged
Conversation
Contributor
Contributor
Contributor
Contributor
|
I verified this build for the failing LDAP testsuite with JDK17, JDK11, JDK8 JVMs, the fix itself looks good and the previously failing tests are all passing now. I am running through the rest of the tests to make sure its not affected and also will connect with @miquelsi to make sure im not missing anything as well. |
miquelsi
approved these changes
Feb 11, 2022
Contributor
There was a problem hiding this comment.
Thanks @kami619 and @douglaspalmer, LGTM! Please @mposolda merge at your earliest convenience.
kami619
added a commit
to kami619/keycloak
that referenced
this pull request
Oct 19, 2022
…for test compatibility with JDK17 Similar to the fix we did for LDAP tests which were failing with JDK17 in the PR keycloak#9980, we need additional packages to be added within those args to allow deep reflection which supports the marshaling of Map behind the system env variables, as part of some tests Closes keycloak#14997
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9899