8000 Avoid unexpected invalid_grant error on offline token refresh when offline session cache limits are configured by danielFesenmeyer · Pull Request #9962 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Avoid unexpected invalid_grant error on offline token refresh when offline session cache limits are configured - #9962

Closed
danielFesenmeyer wants to merge 1 commit into
keycloak:mainfrom
bosch-io:9959-fix-unexpected-offlinesession-refresh-error
Closed

danielFesenmeyer wants to merge 1 commit into
keycloak:mainfrom
bosch-io:9959-fix-unexpected-offlinesession-refresh-error

Conversation

@danielFesenmeyer
Copy link
Copy Markdown
Contributor
  • make sure that for each userSession there is only one clientSession (this improves utilization of userSession and clientSession caches - at least when both are configured with the same maximum number of entries)
  • reload the clientSession from the database, in case it is not found in the cache - update the cache in this case

Closes #9959

…fline session cache limits are configured

- make sure that for each userSession there is only one clientSession (this improves utilization of userSession and clientSession caches - at least when both are configured with the same maximum number of entries)
- reload the clientSession from the database, in case it is not found in the cache - update the cache in this case

Closes #9959
@SimonMacIntyre
Copy link
Copy Markdown

Curious on the status of this PR, it might fix an issue we're experiencing.

@danielFesenmeyer
Copy link
Copy Markdown
Contributor Author

@SimonMacIntyre: I don't know whether this PR would be accepted, otherwise I would rebase to master. Btw, there is a similar PR, which is more simple, and also still open: #8671

@danielFesenmeyer
Copy link
Copy Markdown
Contributor Author

Closing this PR, because the associated issue has now been fixed by PR #17490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected invalid_grant error on offline session refresh when maximum num 3C0F ber of offline sessions is configured

2 participants

0