8000 [#9075] - Remove any unnecessary dependency from distribution by pedroigor · Pull Request #9077 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

[#9075] - Remove any unnecessary dependency from distribution - #9077

Closed
pedroigor wants to merge 1 commit into
keycloak:mainfrom
pedroigor:issue-9075
Closed

pedroigor wants to merge 1 commit into
keycloak:mainfrom
pedroigor:issue-9075

Conversation

@pedroigor
Copy link
Copy Markdown
Contributor

No description provided.

@pedroigor pedroigor added kind/enhancement Categorizes a PR related to an enhancement area/dist/quarkus Quarkus distribution — packaging, container images, server config (kc.sh) labels Dec 10, 2021
@pedroigor pedroigor linked an issue Dec 10, 2021 that may be closed by this pull request
Comment thread quarkus/pom.xml Outdated
Comment on lines 173 to 179
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really following this - why would there be a "distribution" profile, and not just remove the deps always?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running tests we don't want to completely disable the test capabilities from quarkus such as dev services / testcontainers.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^^^^ this.

the profile also allows you to run specific tests in exotic environments. e.g. afaik keycloak java keystore provider is not compatible with BouncyCastle running in FIPS mode (as IIRC, BC FIPS does not support JKS keysstores and the keycloak provider only supports JKS)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case wouldn't you just use the test scope for the dependency instead of a profile?

@pedroigor pedroigor added the status/hold PR should not be merged. On hold for later. label Dec 14, 2021
@pedroigor
Copy link
Copy Markdown
Contributor Author

Blocked by quarkiverse/quarkus-vault#12.

@pedroigor
Copy link
Copy Markdown
Contributor Author

Closing for now as we have some work required from Quarkus to properly remove dependencies for any extension we use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dist/quarkus Quarkus distribution — packaging, container images, server config (kc.sh) kind/enhancement Categorizes a PR related to an enhancement status/hold PR should not be merged. On hold for later.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove any unnecessary dependency from distribution

3 participants

0