8000 KEYCLOAK-19495 Realm key(s) uses - Allowing multivalue fields by laskasn · Pull Request #8539 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

KEYCLOAK-19495 Realm key(s) uses - Allowing multivalue fields - #8539

Closed
laskasn wants to merge 1 commit into
keycloak:mainfrom
eosc-kc:110-keyuses
Closed

KEYCLOAK-19495 Realm key(s) uses - Allowing multivalue fields#8539
laskasn wants to merge 1 commit into
keycloak:mainfrom
eosc-kc:110-keyuses

Conversation

@laskasn
@laskasn laskasn commented Oct 6, 2021
Copy link
Copy Markdown
Contributor

This is the first pull request as described here

@stianst stianst changed the title KEYCLOAK-19495 KEYCLOAK-19495 Realm key(s) uses - Allowing multivalue fields Oct 7, 2021
@mposolda
mposolda commented Aug 7, 2023
Copy link
Copy Markdown
Contributor

@laskasn CC @cgeorgilakis There are some changes in latest Keycloak related to keys and key use etc. Just to confirm, could you please doublecheck if latest Keycloak 22.0.1 doesn't already address your use-case?

@cgeorgilakis
cgeorgilakis commented Aug 22, 2023
8000 Copy link
Copy Markdown
Contributor

@laskasn CC @cgeorgilakis There are some changes in latest Keycloak related to keys and key use etc. Just to confirm, could you please doublecheck if latest Keycloak 22.0.1 doesn't already address your use-case?

@mposolda as I see, what we want is not supported yet in Keycloak.
Our summarized proposal for this PR is :

So, for the first one, we change the exclusiveness of each key’s use for either “enc” or “sig”, and -instead- assign a list of uses for each key i.e. [“enc”, “sig”].

If you want to proceed with this PR, we need to rebase it and move ui changes from old admin console to new admin console.

@stianst
stianst commented Mar 15, 2024
Copy link
Copy Markdown
Contributor

I'm going to close this as I think it adds unnecessary complexity. If anyone really wants to use the same keys for enc and sig that can be done by registering the keys twice, or through a custom key provider.

@stianst stianst closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

team/core-shared

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@laskasn @mposolda @cgeorgilakis @stianst
0