Repository navigation
[KEYCLOAK-19306] - Automatic re-augmentation - #8450
Merged
Merged
Conversation
pedroigor
force-pushed
the
KEYCLOAK-19306
branch
4 times, most recently
from
September 28, 2021 11:34
0c0f56a to
f30c562
Compare
pedroigor
marked this pull request as ready for review
September 28, 2021 13:18
pedroigor
force-pushed
the
KEYCLOAK-19306
branch
from
September 28, 2021 13:53
f30c562 to
64530b0
Compare
pedroigor
force-pushed
the
KEYCLOAK-19306
branch
from
September 28, 2021 17:44
64530b0 to
e8fd800
Compare
pedroigor
force-pushed
the
KEYCLOAK-19306
branch
from
September 28, 2021 20:27
e8fd800 to
27ae5ac
Compare
stianst
approved these changes
Sep 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some highlights:
Run re-augmentation (
configcommand) transparently whenever a build-time property changes. Once run, re-augmentation won't happen again for the same set of CLI arguments.Re-org CLI options so that
start,start-dev, andconfigcommands have the same list of options. If we want to still keep options specific for commands (e.g.: built-time only forconfig) it would add a bit more complexity that I'm not sure makes sense.To make this work, I had to force invalidation of caches kept by Quarkus classloaders. Something not very usual that relies on unsupported APIs.
Alternatively, we could use scripts but I would love to keep our scripts as simple as possible without having to worry about implementing logic for different platforms (windows/linux).