Repository navigation
<
8000
div style="--spacing:var(--spacing-none)" class="prc-PageLayout-PageLayoutRoot--KH-d" data-component="SplitPageLayout" data-has-sidebar="true">
Conversation
laskasn
force-pushed
the
63_ui_enhancement
branch
from
November 25, 2021 16:58
d40f3c3 to
84148c8
Compare
… of client mappers to IdP mappers
laskasn
force-pushed
the
63_ui_enhancement
branch
from
November 25, 2021 17:03
84148c8 to
0f2ee96
Compare
Contributor
|
Closing as the old admin console has been deleted. If still relevant to the new admin console please consider opening a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mappers have a ProviderConfigProperty which defines their additional properties (for both UI and backend). One of the parameters this class has is the "defaultValue". This can be set for both the client and the identity provider mapper config properties. The "defaultValue" is intended to be used as the default value of the property, whenever the keycloak admin tries to create a new mapper of that kind.
For the client mappers there is some angular.js code to load the default value of the properties of the selected mapper, but that doesn't happen for the Identity Provider mappers. The code just ignores the fact that someone might have set a defaultValue for the property.
We added the exact same logic for IdP mapper default values, borrowed from the client mappers and we are contributing this to the community.