8000 Fix broken links in contributor docs by meetRaval09 · Pull Request #55325 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Fix broken links in contributor docs - #55325

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
meetRaval09:fix-doc-links
Nov 20, 2026
Merged

vmuzikar merged 1 commit into
keycloak:mainfrom
meetRaval09:fix-doc-links

Conversation

@meetRaval09
Copy link
Copy Markdown
Contributor

Closes #55324

Fixes three links in the contributor docs that point to things that no longer exist:

  • GOVERNANCE.md: #contributing -> #contributing-changes (the heading is "Contributing Changes")
  • docs/fips.md: ./guides/src/main/server/fips.adoc -> ./guides/server/fips.adoc
  • js/CODING_GUIDELINES.md: .eslintrc.cjs -> eslint.config.js (the project's current ESLint config)

Found with Arachnid, a small open-source checker I'm building. An AI assistant helped me prepare this change; I checked each link myself and understand every line of it.

Closes keycloak#55324

Signed-off-by: Meet Raval <meet.a.techie2k25@gmail.com>
@meetRaval09
meetRaval09 requested review from a team as code owners November 18, 2026 18:10
Copilot AI balanced review requested due to automatic review settings November 18, 2026 18:10
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the contributor-documentation link fixes.

No open issues 🎉

What changed in this PR

Fixes three broken contributor-documentation links identified in #55324. The changes are documentation-only and do not affect runtime behavior.

Changes:

  • Corrects the governance table-of-contents anchor.
  • Updates the FIPS guide and ESLint configuration links to their current paths.
File Description
js/​CODING_GUIDELINES.md Links to eslint.config.js instead of .eslintrc.cjs.
GOVERNANCE.md Points the contributing link to #contributing-changes.
docs/​fips.md Updates the FIPS guide link to ./guides/server/fips.adoc.

Review effort: Balanced

@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @meetRaval09

@vmuzikar
vmuzikar enabled auto-merge (squash) November 20, 2026 15:14
@vmuzikar
vmuzikar merged commit 4b116f4 into keycloak:main Nov 20, 2026
71 checks passed
@meetRaval09
Copy link
Copy Markdown
Contributor Author

Thanks @vmuzikar for the review!

@meetRaval09
meetRaval09 deleted the fix-doc-links branch November 20, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix broken links in contributor docs (GOVERNANCE.md, docs/fips.md, js/CODING_GUIDELINES.md)

3 participants

0