Repository navigation
Fix broken links in contributor docs - #55325
Merged
Merged
Conversation
Closes keycloak#55324 Signed-off-by: Meet Raval <meet.a.techie2k25@gmail.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the contributor-documentation link fixes.
No open issues 🎉
What changed in this PR
Fixes three broken contributor-documentation links identified in #55324. The changes are documentation-only and do not affect runtime behavior.
Changes:
- Corrects the governance table-of-contents anchor.
- Updates the FIPS guide and ESLint configuration links to their current paths.
| File | Description |
|---|---|
js/CODING_GUIDELINES.md |
Links to eslint.config.js instead of .eslintrc.cjs. |
GOVERNANCE.md |
Points the contributing link to #contributing-changes. |
docs/fips.md |
Updates the FIPS guide link to ./guides/server/fips.adoc. |
Review effort: Balanced
vmuzikar
approved these changes
Nov 20, 2026
Contributor
There was a problem hiding this comment.
LGTM, thank you @meetRaval09
vmuzikar
enabled auto-merge (squash)
November 20, 2026 15:14
Contributor
Author
|
Thanks @vmuzikar for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55324
Fixes three links in the contributor docs that point to things that no longer exist:
GOVERNANCE.md:#contributing->#contributing-changes(the heading is "Contributing Changes")docs/fips.md:./guides/src/main/server/fips.adoc->./guides/server/fips.adocjs/CODING_GUIDELINES.md:.eslintrc.cjs->eslint.config.js(the project's current ESLint config)Found with Arachnid, a small open-source checker I'm building. An AI assistant helped me prepare this change; I checked each link myself and understand every line of it.