Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The audit resource path appends the role name twice for realm and client role permission endpoints, recording an incorrect endpoint and preventing expected resource-path filter matches.
1 open issue
What changed in this PR
Adds audit events when fine-grained management permissions are enabled or disabled, addressing the audit gap described in #55145.
Changes:
- Records
UPDATEadmin events with request representations across management-permission endpoints. - Distinguishes client-role and realm-role events and assigns user permission events to the user resource type.
| File | Description |
|---|---|
services/src/main/java/org/keycloak/services/resources/admin/RoleContainerResource.java |
Adds audit events for role-name permission toggles. |
services/src/main/java/org/keycloak/services/resources/admin/RoleByIdResource.java |
Adds audit events for role-ID permission toggles. |
services/src/main/java/org/keycloak/services/resources/admin/RealmAdminResource.java |
Records user management-permission changes. |
services/src/main/java/org/keycloak/services/resources/admin/IdentityProviderResource.java |
Records identity-provider permission changes. |
services/src/main/java/org/keycloak/services/resources/admin/GroupResource.java |
Records group permission changes. |
services/src/main/java/org/keycloak/services/resources/admin/ClientResource.java |
Records client permission changes. |
Review effort: Balanced
sguilhen
force-pushed
the
55145-admin-events-management-permissions
branch
from
November 17, 2026 15:21
0eaab1a to
5d6324f
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The role-permission tests do not verify exactly one UPDATE event with the correct request path, resource type, and enabled representation when permissions are enabled or disabled.
1 open issue
1 resolved since last review
Review effort: Balanced
Closes keycloak#55145 Signed-off-by: Stefan Guilhen <sguilhen@redhat.com>
Signed-off-by: Stefan Guilhen <sguilhen@redhat.com>
sguilhen
force-pushed
the
55145-admin-events-management-permissions
branch
from
November 17, 2026 22:03
8f430a4 to
c330921
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Closes #55145