Repository navigation
Conversation
Closes keycloak#55114 Signed-off-by: kathari00 <katharina.eiserfey1@gmail.com> Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The snapshot lacks the bundled PatternFly 6 CSS, so browser validation with the built theme is needed to confirm OTP hit targets and selected states, clipboard expansion styling, and responsive recovery-code buttons.
No open issues 🎉
What changed in this PR
Aligns Keycloak v3 login pages with PatternFly 6 to address the background, OTP selector, and button styling issues reported in #55114.
Changes:
- Replaces OTP tiles with shared radio-button cards and adds a localized “Default” label for unnamed credentials.
- Adjusts backgrounds, buttons, alerts, clipboard controls, and supporting layouts.
- Updates UI page selectors and OTP tests, including coverage that user-provided credential labels remain unchanged.
| File | Description |
|---|---|
themes/src/main/resources/theme/keycloak.v3/login/theme.properties |
Updates PatternFly classes and adds OTP card styling mappings. |
themes/src/main/resources/theme/keycloak.v3/login/resources/css/styles.css |
Adjusts background sizing and social-button text wrapping. |
themes/src/main/resources/theme/base/login/otp-credential.ftl |
Adds shared OTP selection cards with native radio inputs. |
themes/src/main/resources/theme/base/login/messages/messages_en.properties |
Adds OTP headings and the default credential label. |
themes/src/main/resources/theme/base/login/login-reset-otp.ftl |
Uses shared OTP cards and standard action grouping. |
themes/src/main/resources/theme/base/login/login-recovery-authn-code-config.ftl |
Uses default button widths for recovery-code actions. |
themes/src/main/resources/theme/base/login/login-otp.ftl |
Adopts OTP cards and removes custom selection JavaScript. |
themes/src/main/resources/theme/base/login/login-oid4vp.ftl |
Adjusts expired-code messaging layout and link wrapping. |
themes/src/main/resources/theme/base/login/frontchannel-logout.ftl |
Applies form, list, and full-width button styling. |
themes/src/main/resources/theme/base/login/field.ftl |
Repositions password errors and revises clipboard markup. |
themes/src/main/resources/theme/base/login/delete-account-confirm.ftl |
Uses form-specific alert styling with a fallback. |
testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/forms/LevelOfAssuranceFlowTest.java |
Updates the expected unnamed OTP label. |
testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/forms/BrowserFlowTest.java |
Updates label expectations and tests literal user-label rendering. |
testsuite/integration-arquillian/tests/base/src/main/java/org/keycloak/testsuite/pages/ResetOtpPage.java |
Selects OTP credentials through radio labels. |
testsuite/integration-arquillian/tests/base/src/main/java/org/keycloak/testsuite/pages/LoginTotpPage.java |
Updates selectors for radio-based OTP cards. |
test-framework/ui/src/main/java/org/keycloak/testframework/ui/page/LoginTotpPage.java |
Updates framework selectors for the new OTP markup. |
services/src/main/java/org/keycloak/forms/login/freemarker/model/TotpLoginBean.java |
Preserves raw credential labels for template-level fallback handling. |
services/src/main/java/org/keycloak/authentication/authenticators/browser/OTPFormAuthenticator.java |
Removes the hard-coded unnamed credential label constant. |
Review effort: Balanced
edewit
previously approved these changes
Nov 12, 2026
…atting Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The selectable-card and clipboard markup depends on PatternFly 6 CSS missing from this checkout, leaving keyboard selection, focus indicators, and responsive layouts pending browser validation.
No open issues 🎉
Review effort: Balanced
edewit
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For instance, new OTP form (instead of "unnamed", there's the localized "Default"):
@edewit @kathari00 @vaceksimon Please review