Repository navigation
Remove the non-atomic default implementations of the credential update methods - #55078
Merged
ahus1 merged 1 commit intoNov 12, 2026
Merged
Conversation
Closes keycloak#55034 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
ahus1
force-pushed
the
is-55034-remove-default-atomic-credential-update
branch
from
November 12, 2026 09:20
61f54b7 to
d01ae34
Compare
ahus1
marked this pull request as ready for review
November 12, 2026 10:08
ahus1
enabled auto-merge (squash)
November 12, 2026 10:08
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the change requiring atomic conditional credential updates.
No open issues 🎉
What changed in this PR
Removes the non-atomic credential-update defaults introduced in #55030, requiring custom implementations to provide atomic compare-and-swap behavior for Keycloak 27.0.
Changes:
- Makes the three conditional credential-update methods abstract.
- Updates their Javadoc to require atomic comparison and replacement.
- Documents the breaking change and migration requirements in the 27.0 upgrading guide.
| File | Description |
|---|---|
server-spi/src/main/java/org/keycloak/models/SubjectCredentialManager.java |
Removes the default conditional update and requires atomic behavior. |
server-spi/src/main/java/org/keycloak/credential/UserCredentialStore.java |
Makes conditional credential updates mandatory for store implementations. |
model/storage/src/main/java/org/keycloak/storage/federated/UserFederatedUserCredentialStore.java |
Applies the same requirement to federated credential stores. |
docs/documentation/upgrading/topics/changes/changes-27_0_0.adoc |
Documents the removed defaults and requirements for custom implementations. |
Review effort: Balanced
pedroigor
approved these changes
8000
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55034
Follow-up of #55030, which introduced the default implementations for backwards compatibility.
Decisions and assumptions