Repository navigation
Disable X25519MLKEM768 for Maven in FIPS tests - #54399
Merged
Merged
Conversation
Closes keycloak#54398 Signed-off-by: stianst <stianst@gmail.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues blocking the FIPS test-script changes.
No open issues 🎉
What changed in this PR
Updates the FIPS test scripts to exclude X25519MLKEM768 from Maven’s TLS named groups, addressing the artifact-download failures reported in #54398.
Changes:
- Adds an explicit TLS named-group list to
MAVEN_OPTSfor both unit and integration tests, preserving existing options. - Documents why the workaround is needed for JDK 25.0.5+ in FIPS mode.
| File | Description |
|---|---|
.github/scripts/run-fips-ut.sh |
Configures Maven TLS groups for FIPS unit-test runs. |
.github/scripts/run-fips-it.sh |
Applies the same configuration to FIPS integration-test runs. |
Review effort: Balanced
stianst
marked this pull request as draft
October 28, 2026 06:51
stianst
marked this pull request as ready for review
October 28, 2026 07:31
rmartinc
approved these changes
Oct 28, 2026
Contributor
vmuzikar
pushed a commit
that referenced
this pull request
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54398
Signed-off-by: stianst stianst@gmail.com