Repository navigation
Conversation
The class had no callers; only two commented-out references remained in SignatureUtil and XMLSignatureUtil, which are removed as well. Closes keycloak#53853 Signed-off-by: OnicarN <ebaudani@gmail.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The deleted utility has no remaining repository references, and the other changes only remove comments.
No open issues 🎉
What changed in this PR
Removes the unused internal JAXBUtil class from saml-core, addressing #53853 without changing the public SAML API or live signature logic.
Changes:
- Deletes the unused JAXB utility and its cache and resource-handling code.
- Removes two obsolete commented-out references to
JAXBUtil.
| File | Description |
|---|---|
saml-core/src/main/java/org/keycloak/saml/processing/core/util/XMLSignatureUtil.java |
Removes a commented-out JAXB marshalling example. |
saml-core/src/main/java/org/keycloak/saml/processing/core/util/JAXBUtil.java |
Deletes the unused internal utility class. |
saml-core/src/main/java/org/keycloak/saml/processing/core/saml/v2/util/SignatureUtil.java |
Removes a commented-out JAXB marshalling example. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class had no callers; only two commented-out references remained in SignatureUtil and XMLSignatureUtil, which are removed as well.
Closes #53853