Repository navigation
Do not assign CURRENT_AUTHENTICATION_EXECUTION on fork - #54205
Merged
Merged
Conversation
8000
Closes keycloak#54176 Signed-off-by: rmartinc <rmartinc@redhat.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The isolated removal matches the issue requirements, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Removes unnecessary authentication-execution tracking when a flow forks, addressing #54176.
Changes:
- Stops setting
CURRENT_AUTHENTICATION_EXECUTIONin theFORKbranch. - Leaves fork exception handling unchanged.
| File | Description |
|---|---|
| services/src/main/java/org/keycloak/authentication/DefaultAuthenticationFlow.java | Removes the execution-note assignment on fork. |
Review effort: Balanced
mabartos
approved these changes
Oct 21, 2026
Member
There was a problem hiding this comment.
Yep, not needed for FORK, so let's remove it to be more safe.
ahus1
approved these changes
Oct 21, 2026
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54176
Just not assigning the CURRENT_AUTHENTICATION_EXECUTION on fork. It's not needed and I prefer to not ste anything here.