8000 7FFF BACKPORT 26.6 Prevent Vault secret resolution and injection in DCR client secrets (… by jimmychakkalakal · Pull Request #54983 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

BACKPORT 26.6 Prevent Vault secret resolution and injection in DCR client secrets (… - #54983

Merged
mposolda merged 1 commit into
keycloak:release/26.6from
jimmychakkalakal:backport-54463-26.6
Nov 11, 2026
Merged

BACKPORT 26.6 Prevent Vault secret resolution and injection in DCR client secrets (…#54983
mposolda merged 1 commit into
keycloak:release/26.6from
jimmychakkalakal:backport-54463-26.6

Conversation

@jimmychakkalakal
@jimmychakkalakal jimmychakkalakal commented Nov 10, 2026
Copy link
Copy Markdown
Contributor

…#54463)

Closes #54382

(cherry picked from commit df2914e)

@jimmychakkalakal
jimmychakkalakal requested a review from a team as a code owner November 10, 2026 11:56
@mposolda mposolda self-assigned this Nov 10, 2026
mposolda
mposolda reviewed Nov 10, 2026
View reviewed changes
@mposolda mposolda left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimmychakkalakal The build failures in the testsuite are real issues. AFAIK in 26.6, the class like ClientBuilder was named ClientConfigBuilder or something like this. I guess that might be the reason of the test failure...

@jimmychakkalakal
Prevent Vault secret resolution and injection in DCR client secrets (k…
8bf43aa 
…eycloak#54463)

Closes keycloak#54382

Signed-off-by: Jimmy Chakkalakal <jimmy.chakkalakal@ibm.com>
(cherry picked from commit df2914e)
Signed-off-by: Jimmy Chakkalakal <jimmy.chakkalakal@ibm.com>
@jimmychakkalakal jimmychakkalakal changed the title Prevent Vault secret resolution and injection in DCR client secrets (… BACKPORT 26.6 Prevent Vault secret resolution and injection in DCR client secrets (… Nov 10, 2026
@jimmychakkalakal
jimmychakkalakal commented Nov 10, 2026
Copy link
Copy Markdown
Contributor Author

@jimmychakkalakal The build failures in the testsuite are real issues. AFAIK in 26.6, the class like ClientBuilder was named ClientConfigBuilder or something like this. I guess that might be the reason of the test failure...

Thanks

@jimmychakkalakal The build failures in the testsuite are real issues. AFAIK in 26.6, the class like ClientBuilder was named ClientConfigBuilder or something like this. I guess that might be the reason of the test failure...

Thanks @mposolda I have updated the test.

mposolda
mposolda approved these changes Nov 11, 2026
View reviewed changes
@mposolda mposolda left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimmychakkalakal Thanks!

@mposolda
mposolda merged commit e0da916 into keycloak:release/26.6 Nov 11, 2026
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes

Assignees

@mposolda mposolda

Labels

team/core-protocols

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jimmychakkalakal @mposolda
0