8000 Filter role mappings by visibility in group lookup by path by pedroigor · Pull Request #54919 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Filter role mappings by visibility in group lookup by path - #54919

Closed
pedroigor wants to merge 1 commit into
keycloak:release/26.8from
pedroigor:issue-54356-26.8
Closed

Filter role mappings by visibility in group lookup by path#54919
pedroigor wants to merge 1 commit into
keycloak:release/26.8from
pedroigor:issue-54356-26.8

Conversation

@pedroigor
@pedroigor pedroigor commented Nov 9, 2026
Copy link
Copy Markdown
Contributor

closes: #54356

(cherry picked from commit 95ef67c)

@pedroigor
pedroigor requested a review from a team as a code owner November 9, 2026 14:58
@pedroigor
pedroigor commented Nov 9, 2026
Copy link
Copy Markdown
Contributor Author

The tests were adapted to the existing 26.8 fixtures, which lack the upstream groupListings() helper and parent/child setup. The backport checks path-based lookup alongside the existing by-ID assertions, covering role visibility for manage-users, view-users, and fine-grained map-role permissions.

Coverage is narrower than upstream: nested paths and the inaccessible-parent 404 case are not included.

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Nov 9, 2026
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Nov 9, 2026
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.account.WebAuthnSigningInTest#createWebAuthnSameUserLabel

Keycloak CI - WebAuthn IT

org.openqa.selenium.WebDriverException: 
unknown error: unhandled inspector error: {"code":-32000,"message":"Node with given id does not belong to the document"}
  (Session info: chrome=156.0.8078.79)
Build info: version: '4.46.0', revision: 'df5a634 df5a6341cbb5f8f06b836bd595752775627c80dc'
System info: os.name: 'Linux', os.arch: 'amd64', os.version: '7.0.0-1019-azure', java.version: '25.0.5'
...

Report flaky test

@michalvavrik @pedroigor
Filter role mappings by visibility in group lookup by path
77f8f15 
closes: keycloak#54356

Signed-off-by: Michal Vavřík <dev@michalvavrik.net>

(cherry picked from commit 95ef67c)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pedroigor
pedroigor commented Nov 12, 2026
Copy link
Copy Markdown
Contributor Author

Closed by #54630

@pedroigor pedroigor closed this Nov 12, 2026
@pedroigor
pedroigor deleted the issue-54356-26.8 branch November 12, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pedroigor @michalvavrik
0