8000 Make the HTTP lifecycle bound to the Keycloak instance by ahus1 · Pull Request #54811 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Make the HTTP lifecycle bound to the Keycloak instance #54811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ahus1 wants to merge 1 commit into
base: release/26.6
Choose a base branch
from
+6 −1
Draft

Make the HTTP lifecycle bound to the Keycloak instance #54811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion test-framework/core/src/main/java/org/keycloak/testframework/http/HttpClientSupplier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import org.keycloak.testframework.injection.LifeCycle;
import org.keycloak.testframework.injection.RequestedInstance;
import org.keycloak.testframework.injection.Supplier;
import org.keycloak.testframework.server.KeycloakServer;

import org.apache.http.client.HttpClient;
import org.apache.http.conn.ssl.SSLConnectionSocketFactory;
Expand All @@ -22,13 +23,17 @@ public class HttpClientSupplier implements Supplier<HttpClient, InjectHttpClient

@Override
public List<Dependency> getDependencies(RequestedInstance<HttpClient, InjectHttpClient> instanceContext) {
return DependenciesBuilder.create(ManagedCertificates.class).build();
// The pooled connections must not outlive the server, as the server can be restarted between test classes
return DependenciesBuilder.create(ManagedCertificates.class).add(KeycloakServer.class).build();
}

@Override
public HttpClient getValue(InstanceContext<HttpClient, InjectHttpClient> instanceContext) {
HttpClientBuilder builder = HttpClientBuilder.create();

// Retrieving the dependency registers this client as its dependent, so it is closed when the server is replaced
instanceContext.getDependency(KeycloakServer.class);

ManagedCertificates managedCerts = instanceContext.getDependency(ManagedCertificates.class);

if (managedCerts.isTlsEnabled()) {
Expand Down
Loading
0