Repository navigation
Show credentials of disabled users in admin console - #54778
Merged
Merged
Conversation
Closes keycloak#54777 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Andy <andy@slice.is>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change restoring credential visibility for disabled local users.
No open issues 🎉
What changed in this PR
Restores credential visibility for disabled, non-federated users in the admin console, addressing #54777 while preserving the safeguard for disabled federated users.
Changes:
- Fetches credentials when a user is enabled or has no federation link.
- Adds a Playwright regression test confirming that a disabled local user’s password credential is displayed.
| File | Description |
|---|---|
js/apps/admin-ui/test/users/main.spec.ts |
Tests password credential visibility for a disabled local user. |
js/apps/admin-ui/src/user/UserCredentials.tsx |
Limits skipped credential requests to disabled federated users. |
Review effort: Balanced
edewit
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54777
#39764 stopped fetching credentials for every disabled user to avoid the crash for orphaned LDAP users (#39715). With this change the fetch is skipped only for disabled users that are federated, so other disabled users' credentials are shown again. Adds a Playwright test.
This is an interim fix: disabled LDAP users that aren't orphaned still show no credentials, because the UI can't tell them apart from orphaned ones. A fuller fix would be for
LDAPStorageProvider.getCredentialsto return an empty stream instead of throwing when the LDAP entry is missing (as suggested in #39715). The UI check could then be removed. Happy to change this PR to that approach if preferred.AI disclosure: written with help from Claude Code. I reviewed and understand every change.