Repository navigation
Conversation
WebAuthn registration logged out the user's other sessions before it checked the attestation. When the registration failed, the other sessions were gone anyway. The logout now runs after the credential is created. Closes keycloak#54352 Signed-off-by: Luca Marsella <34103646+marsluca@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54352
WebAuthnRegister.processActionlogged out the other sessions before it parsed and verified the attestation, so a failed registration still ended them. I moved the logout to right aftercreateCredential, so it only runs once the passkey is saved. This also covers the passwordless register action, which extends this class.Testing:
AppInitiatedActionWebAuthnTest#failedSetupWebAuthnKeepsOtherSessions: two sessions, "sign out other devices" checked, and an invalid attestation object, so the server rejects the registration. It checks that both sessions are still there. It fails on main (2 sessions become 1) and passes with the fix. It also runs inAppInitiatedActionPwdLessTestandAppInitiatedActionWebAuthnSkipIfExistsTest.tests/webauthnmodule (71 tests), locally.AI-assisted (Claude Code).