Repository navigation
Name the direct membership checkboxes in the Account Console Groups page - #54773
Open
atishay-kasliwal wants to merge 1 commit into
Open
atishay-kasliwal wants to merge 1 commit into
atishay-kasliwal wants to merge 1 commit into
Conversation
Closes keycloak#54361 Signed-off-by: Atishay Kasliwal <katishay@gmail.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the change adding group-specific accessible names to membership checkboxes.
No open issues 🎉
What changed in this PR
Addresses #54361 by giving each direct-membership checkbox on the Account Console Groups page an accessible name. Labels use the full group path to distinguish groups with identical names under different parents.
Changes:
- Adds a translated, group-specific
aria-labelto each row checkbox. - Introduces the
groupDirectMembershipmessage key. - Adds a regression test for parent-group and subgroup checkbox names.
| File | Description |
|---|---|
js/apps/account-ui/test/groups.spec.ts |
Tests accessible checkbox names for /one and /one/subgroup. |
js/apps/account-ui/src/groups/Groups.tsx |
Labels row checkboxes using the translated message and group path. |
js/apps/account-ui/maven-resources/theme/keycloak.v3/account/messages/messages_en.properties |
Adds the English message with a group-path placeholder. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54361
I used the group path rather than the name in the label, because groups under different parents can share a name, which would leave two checkboxes with the same accessible name.
The label uses a new
groupDirectMembershipmessage key rather than joining strings, so translators can reorder it.I added a test to
groups.spec.tsthat fails without this change and passes with it. I ran the Groups tests in Chromium against a nightly server with this message file patched into the account theme. ESLint, TypeScript and Prettier pass.Assisted-by: Claude Opus 5.5