Repository navigation
Allow any order in Should save several allowed Kerberos realms kerberos test - #54717
Merged
Merged
Conversation
…os test Closes keycloak#54716 Signed-off-by: rmartinc <rmartinc@redhat.com>
Contributor
Author
|
@michalvavrik Can you please do a quick review for this? 😄 |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the Kerberos realm test update.
No open issues 🎉
What changed in this PR
Addresses #54716 by making the Admin UI Kerberos realm test accept either order of saved allowlist values, avoiding failures caused by reordered configuration entries.
Changes:
- Waits for both realm inputs to contain non-whitespace values.
- Verifies that both expected realms are present without requiring a specific order.
| File | Description |
|---|---|
js/apps/admin-ui/test/user-federation/kerberos.spec.ts |
Replaces order-dependent realm assertions with an unordered comparison. |
Review effort: Balanced
michalvavrik
approved these changes
Nov 5, 2026
Member
There was a problem hiding this comment.
Thanks for the fix. This will have to be backported together with the other PR.
ahus1
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54716
The test added in #54271 is flaky. The order can be different. For the moment just changing the test to check any order is valid.