Repository navigation
Fix crash and inconsistent matching in account console linked-account… - #54652
Merged
pedroigor merged 1 commit intoNov 6, 2026
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Locale-dependent lowercasing causes GIT* to miss github and gitlab under a Turkish JVM locale; the method should use Locale.ROOT consistently.
1 open issue
What changed in this PR
This PR addresses #54647 by preventing linked-account search crashes on single-character inputs and aligning case-insensitive matching across linked and unlinked providers.
Changes:
- Guard paired-delimiter parsing and handle a lone quote before querying unlinked providers.
- Make non-exact linked-provider searches case-insensitive.
- Add regression tests for uppercase searches and bare
*and"inputs.
| File | Description |
|---|---|
| tests/base/src/test/java/org/keycloak/tests/account/LinkedAccountsRestServiceTest.java | Adds case-insensitive and edge-case search coverage for both provider lists. |
| services/src/main/java/org/keycloak/services/resources/account/LinkedAccountsResource.java | Guards delimiter parsing, normalizes lone-quote searches, and adds case-insensitive matching. |
Review effort: Balanced
sguilhen
force-pushed
the
54647-linked-accounts-search-fix
branch
from
November 5, 2026 12:33
d4406d0 to
22800b2
Compare
pedroigor
approved these changes
Nov 6, 2026
…s search Closes keycloak#54647 Signed-off-by: Stefan Guilhen <sguilhen@redhat.com>
pedroigor
force-pushed
the
54647-linked-accounts-search-fix
branch
from
November 6, 2026 13:11
22800b2 to
1d23fae
Compare
pedroigor
enabled auto-merge (rebase)
November 6, 2026 13:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s search
Closes #54647