Repository navigation
Fail assigning an ID when creating resources - #54603
Merged
Merged
Conversation
Closes keycloak#54452 Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the change rejecting client-supplied IDs during UMA resource registration.
No open issues 🎉
What changed in this PR
This PR addresses #54452 by rejecting client-supplied IDs during UMA resource registration, preventing callers from modifying existing resources through the creation endpoint.
Changes:
- Return HTTP 400 when a resource creation request includes an ID.
- Add an integration test verifying that rejected requests leave existing resources unchanged and normal creation still generates an ID.
| File | Description |
|---|---|
tests/base/src/test/java/org/keycloak/tests/authz/services/uma/ProtectionApiTest.java |
Adds regression coverage for cross-user overwrite prevention and normal resource creation. |
services/src/main/java/org/keycloak/authorization/protection/resource/ResourceService.java |
Rejects resource creation requests containing a client-supplied ID. |
Review effort: Balanced
vramik
approved these changes
Nov 4, 2026
ahus1
approved these changes
Nov 4, 2026
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54452