Repository navigation
[Quarkus 4] Replace the mock instance tracker's internal Vert.x collection - #54593
Merged
Merged
Conversation
…ction Closes: keycloak#54592 Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change cleanly replaces the removed Vert.x collection with JDK concurrent sets while preserving thread-safe tracking and reset behavior, with no active review issues identified.
No open issues 🎉
What changed in this PR
Replaces Vert.x’s removed internal ConcurrentHashSet with JDK concurrent sets in the mock instance tracker, maintaining thread-safe behavior for Quarkus 4 compatibility.
Changes:
- Removes the internal Vert.x collection dependency.
- Uses
ConcurrentHashMap.newKeySet()for active and closed mock instances. - Preserves existing set operations and reset behavior.
| File | Description |
|---|---|
test-framework/core/src/test/java/org/keycloak/testframework/injection/mocks/MockInstances.java |
Replaces Vert.x concurrent sets with JDK concurrent sets. |
Review effort: Lite
shawkins
approved these changes
Nov 3, 2026
8 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #54592
This can directly go to
main.