Repository navigation
fix: ensuring persisted state does not leak into builds - #54494
Merged
Merged
Conversation
closes: keycloak#54455 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the changes isolating build-time feature and option selection from persisted configuration.
No open issues 🎉
What changed in this PR
Addresses #54455 by preventing persisted configuration from influencing feature and option selection during explicit builds and potential auto-builds.
Changes:
- Disables persisted configuration while initializing the feature profile and evaluating enabled property mappers for builds.
- Adds regression tests for persisted metrics settings and feature-dependent selection of the Hibernate Validator extension.
| File | Description |
|---|---|
quarkus/runtime/src/test/java/org/keycloak/quarkus/runtime/cli/PicocliTest.java |
Adds regression coverage for persisted configuration leaking into subsequent builds. |
quarkus/runtime/src/main/java/org/keycloak/quarkus/runtime/configuration/mappers/PropertyMappers.java |
Excludes persisted values from build-time feature initialization and mapper enablement checks. |
Review effort: Balanced
ruchikajha95
pushed a commit
to ruchikajha95/keycloak
that referenced
this pull request
Nov 3, 2026
closes: keycloak#54455 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
shawkins
added a commit
to shawkins/keycloak
that referenced
this pull request
Nov 6, 2026
closes: keycloak#54455 Signed-off-by: Steve Hawkins <shawkins@redhat.com> (cherry picked from commit a3d75dc)
vmuzikar
pushed a commit
that referenced
this pull request
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The profile and property mappers were being evaluated against the persisted state.
closes: #54455