8000 Use the docker runtime in the operator minikube quick start by marsluca · Pull Request #54436 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Use the docker runtime in the operator minikube quick start - #54436

Merged
shawkins merged 1 commit into
keycloak:mainfrom
marsluca:operator-readme-minikube-runtime
Oct 29, 2026
Merged

shawkins merged 1 commit into
keycloak:mainfrom
marsluca:operator-readme-minikube-runtime

Conversation

@marsluca
Copy link
Copy Markdown
Contributor

Closes #52871

The quick start builds the operator image with the Minikube Docker daemon (eval $(minikube -p minikube docker-env)). minikube v1.39.0 changed the default container runtime to containerd, and the build fails there, so I added --container-runtime=docker to the minikube start command with a short note on why. I also dropped "with JIB" from the build step, since the image is built from operator/Dockerfile now.

Tested on macOS with minikube v1.39.0 and the Docker Desktop driver, running the quick start steps (with -DskipTests on the build):

  • With the current command the cluster runs containerd 2.3.4. docker-env falls back to its experimental containerd mode, and the image build fails with failed to inspect pulled image moby/buildkit:buildx-stable-1: Error response from daemon: 404 page not found.
  • With --container-runtime=docker the build puts keycloak/keycloak-operator:999.0.0-SNAPSHOT into the Minikube Docker daemon, and after kubectl apply -k target/kubernetes the operator pod starts from that image without pulling it.

Operator CI pins minikube v1.38.0, so it isn't affected yet, but it would hit the same failure after a bump to v1.39.0.

AI-assisted (Claude Code).

The quick start builds the operator image with the Minikube Docker
daemon. Since minikube v1.39.0 the default container runtime is
containerd, where that build fails, so set --container-runtime=docker.
Also drop "with JIB" from the build step, as the image is built from
operator/Dockerfile.

Closes keycloak#52871

Signed-off-by: Luca Marsella <34103646+marsluca@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 29, 2026 09:08
@marsluca
marsluca requested a review from a team as a code owner October 29, 2026 09:08
@marsluca
marsluca requested a review from a team as a code owner October 29, 2026 09:08
8000 Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@marsluca
marsluca requested a balanced review from Copilot October 29, 2026 09:15
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the Minikube quick-start documentation update.

No open issues 🎉

Review effort: Balanced

@shawkins shawkins left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @marsluca for the PR.

@shawkins
shawkins merged commit 2c2575c into keycloak:main Oct 29, 2026
73 checks passed
ruchikajha95 pushed a commit to ruchikajha95/keycloak that referenced this pull request Nov 3, 2026
…#54436)

The quick start builds the operator image with the Minikube Docker
daemon. Since minikube v1.39.0 the default container runtime is
containerd, where that build fails, so set --container-runtime=docker.
Also drop "with JIB" from the build step, as the image is built from
operator/Dockerfile.

Closes keycloak#52871

Signed-off-by: Luca Marsella <34103646+marsluca@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keycloak operator readme needs clarification

3 participants

0