Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Disabled-realm handling, empty-state UX, and end-to-end coverage need addressing.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (4)
What changed in this PR
Adds organization selection to fine-grained admin permissions and evaluation.
Changes:
- Registers and implements an organization picker.
- Sends selected organization IDs during evaluation.
- Adds English organization-selection messages.
| File | Description |
|---|---|
ResourceType.tsx |
Registers organization resources. |
OrganizationSelect.tsx |
Implements organization selection. |
PermissionsEvaluationTab.tsx |
Maps organizations into evaluation requests. |
messages_en.properties |
Adds picker translations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The organization resource must be hidden when organizations are disabled, and evaluation behavior needs an end-to-end assertion.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new documentation contains a broken cross-reference that should target the heading’s explicit ID.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (4)
Resolved since last review (2)
Selecting "Specific Organizations" in a Fine-Grained Admin Permissions permission rendered no picker, because "organizations" was missing from the resource-type component map. Add an OrganizationSelect modeled on the client picker and register it. The permission evaluation tab reuses the same component map, so also handle Organizations there. Removing an organization marks the form dirty so the search dropdown enables its Search button. Closes keycloak#50830 Signed-off-by: Danny <117714228+UCNDanny@users.noreply.github.com>
Closes #50830
"Specific Organizations" in fine-grained admin permissions had no way to pick
an organization, because organizations weren't in the resource type map. This
adds the picker and makes the evaluation tab send the selected organization.
#51717 is open for the same issue. Sorry for the overlap, I only found it
after I'd built this.
I wrote this with Claude's help.