Repository navigation
Conversation
closes: keycloak#52731 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unrelated PATCH requests can rotate client secrets, and existing tests remain incompatible with the new contract.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (3)
What changed in this PR
Restricts Admin API v2 client-secret responses to newly generated or rotated secrets.
Changes:
- Omits persisted secrets from model mappings.
- Returns secrets only after generation or rotation.
- Documents the revised API contract.
| File | Description |
|---|---|
OIDCClientModelSchema.java |
Stops copying persisted secrets. |
ClientResourceTypeProvider.java |
Tracks and returns generated secrets. |
OIDCClientRepresentation.java |
Documents secret visibility. |
openapi.json |
Updates generated API documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #52197
Strict interpretation of the medium term goal - #52197 (comment)
The only real downside is that we'll need to change a lot of tests.
Other possible behaviors:
@vmuzikar @abstractj can I get a confirmation on the direction here?
closing to discuss more on the issue