Repository navigation
Regression with Trust Email when the userinfo endpoint is used - #53580
Merged
Merged
Conversation
Closes keycloak#53471 Signed-off-by: Martin Kanis <mkanis@ibm.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation, regression test, and documentation consistently address the reported behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes OIDC brokering so a missing UserInfo email_verified claim falls back to the Trust Email setting.
Changes:
- Preserves
nullfor an absentemail_verifiedclaim. - Adds regression coverage for UserInfo-based email import.
- Clarifies Trust Email documentation.
| File | Description |
|---|---|
services/.../OIDCIdentityProvider.java |
Corrects missing-claim handling. |
tests/.../KcOidcBrokerTest.java |
Adds regression test coverage. |
docs/.../configuration.adoc |
Documents ID token and UserInfo behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
pedroigor
approved these changes
Oct 6, 2026
msdaly200
added a commit
to msdaly200/keycloak
that referenced
this pull request
Nov 12, 2026
…eycloak#54245 Also includes the Trust Email docs change and UserInfo email_verified parsing fix from keycloak#53580. Closes keycloak#53471 Signed-off-by: Marie Daly <marie.daly1@ibm.com> (cherry picked from commit 585294c) (cherry picked from commit 34bcada)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #53471