8000 Conditionalize reference to github to only be upstream by andymunro · Pull Request #53511 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Conditionalize reference to github to only be upstream - #53511

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
andymunro:53510
Oct 14, 2026
Merged

Conditionalize reference to github to only be upstream#53511
vmuzikar merged 1 commit into
keycloak:mainfrom
andymunro:53510

Conversation

@andymunro
@andymunro andymunro commented Oct 4, 2026
Copy link
Copy Markdown
Contributor

Closes #53510

@andymunro
andymunro requested review from a team as code owners October 4, 2026 19:04
Copilot AI balanced review requested due to automatic review settings October 4, 2026 19:04
Copilot AI reviewed Oct 4, 2026
View reviewed changes
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The community block incorrectly begins with a closing directive, leaving the template unbalanced.

Review effort: Balanced
Findings: 1 High severity

Open (1)
What changed in this PR

Conditionally limits the GitHub Discussion reference to community documentation.

Changes:

  • Wraps the discussion link in a community-profile directive.
File Description
docs/​guides/​server/​containers.adoc Adds profile directives around the GitHub Discussion link.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/guides/server/containers.adoc Resolved
Copilot AI balanced review requested due to automatic review settings October 4, 2026 21:55
Copilot AI reviewed Oct 4, 2026
View reviewed changes
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The conditional block begins with an unmatched closing directive.

Review effort: Balanced
Findings: 1 High severity · 1 Medium severity

Open (2)
10BC8

Comment thread docs/guides/server/containers.adoc Resolved
Copilot AI balanced review requested due to automatic review settings October 4, 2026 23:03
Copilot AI reviewed Oct 4, 2026
View reviewed changes
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The profile conditional matches existing documentation conventions and fulfills the issue requirement.

Review effort: Balanced
Findings: None

Resolved since last review (2)

Copilot AI balanced review requested due to automatic review settings October 6, 2026 13:11
Copilot AI reviewed Oct 6, 2026
View reviewed changes
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The profile conditional follows existing documentation conventions and addresses the reported downstream leak.

Review effort: Balanced
Findings: None

Copilot AI balanced review requested due to automatic review settings October 6, 2026 23:43
Copilot AI reviewed Oct 6, 2026
View reviewed changes
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The conditional follows existing documentation patterns and correctly limits the link to community builds.

Review effort: Balanced
Findings: None

Copilot AI balanced review requested due to automatic review settings October 8, 2026 11:56
Copilot AI reviewed Oct 8, 2026
View reviewed changes
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The profile conditional follows existing documentation patterns and addresses the reported downstream exposure.

0 open findings

🧠 Review effort: Balanced

Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Copilot AI balanced review requested due to automatic review settings October 9, 2026 19:08
Copilot AI reviewed Oct 9, 2026
View reviewed changes
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The profile conditional correctly addresses the reported downstream documentation issue.

0 open findings

🧠 Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 12, 2026 17:28
@andymunro
andymunro commented Oct 12, 2026
Copy link
Copy Markdown
Contributor Author

Okay thanks, @vmuzikar. I removed it from upstream also.

Copilot AI reviewed Oct 12, 2026
View reviewed changes
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The link should be conditionally retained for upstream documentation rather than removed entirely.

1 open finding

🧠 Review effort: Balanced

Comment thread docs/guides/server/containers.adoc Resolved
Copilot AI balanced review requested due to automatic review settings October 12, 2026 17:36
Copilot AI reviewed Oct 12, 2026
View reviewed changes
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

Still open (1)

Copilot AI balanced review requested due to automatic review settings October 12, 2026 17:45
Copilot AI reviewed Oct 12, 2026
View reviewed changes
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The profile conditional matches established documentation patterns and fulfills the linked issue.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced

@andymunro
andymunro commented Oct 12, 2026
Copy link
Copy Markdown
Contributor Author

Conditionalizing added back to this statement as requested by copilot.

Copilot AI balanced review requested due to automatic review settings October 14, 2026 10:25
Copilot AI reviewed Oct 14, 2026
View reviewed changes
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused documentation removal is correct and has no unresolved issues.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 14, 2026 12:20
Copilot AI reviewed Oct 14, 2026
View reviewed changes
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused documentation removal resolves the reported downstream issue without affecting technical guidance.

0 open findings

🧠 Review effort: Balanced

@andymunro
Conditionalize reference to github to only be upstream
abff5c9 
Closes keycloak#53510

Signed-off-by: AndyMunro <amunro@redhat.com>
@vmuzikar
vmuzikar merged commit ad10f34 into keycloak:main Oct 14, 2026
72 checks passed
andymunro added a commit to andymunro/keycloak that referenced this pull request Oct 14, 2026
@andymunro
Conditionalize reference to github to only be upstream (keycloak#53511)
f2a3d7f 
Closes keycloak#53510

Signed-off-by: AndyMunro <amunro@redhat.com>
andymunro added a commit to andymunro/keycloak that referenced this pull request Oct 14, 2026
@andymunro
Conditionalize reference to github to only be upstream (keycloak#53511)
ac4eae2 
Closes keycloak#53510

Signed-off-by: AndyMunro <amunro@redhat.com>
andymunro added a commit to andymunro/keycloak that referenced this pull request Oct 15, 2026
@andymunro
Conditionalize reference to github to only be upstream (keycloak#53511)
6b35d9e 
Closes keycloak#53510

Signed-off-by: AndyMunro <amunro@redhat.com>
PadzerButch pushed a commit to PadzerButch/-50764_test_migration_keycloak that referenced this pull request Oct 22, 2026
@andymunro @PadzerButch
Conditionalize reference to github to only be upstream (keycloak#53511)
6846cc7 
Closes keycloak#53510

Signed-off-by: AndyMunro <amunro@redhat.com>
PadzerButch pushed a commit to PadzerButch/-50764_test_migration_keycloak that referenced this pull request Oct 23, 2026
@andymunro @PadzerButch
Conditionalize reference to github to only be upstream (keycloak#53511)
e6663dd 
Closes keycloak#53510

Signed-off-by: AndyMunro <amunro@redhat.com>
andymunro added a commit to andymunro/keycloak that referenced this pull request Oct 26, 2026
@andymunro
Conditionalize reference to github to only be upstream (keycloak#53511)
5cc74ed 
Closes keycloak#53510

Signed-off-by: AndyMunro <amunro@redhat.com>
andymunro added a commit to andymunro/keycloak that referenced this pull request Nov 6, 2026
@andymunro
Conditionalize reference to github to only be upstream (keycloak#53511)
caa47bc 
Closes keycloak#53510

Signed-off-by: AndyMunro <amunro@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@vmuzikar vmuzikar vmuzikar approved these changes

Assignees

No one assigned

Labels

backport/26.6 backport/26.8 team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Github discussion reference should only be upstream

4 participants

@andymunro @vmuzikar @stianst
0