8000 fix: do not leak SCIM resource existence to unauthorized callers by waterWang · Pull Request #52151 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

fix: do not leak SCIM resource existence to unauthorized callers #52151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedroigor merged 1 commit into from
Sep 3, 2026
+33 −0
Merged

fix: do not leak SCIM resource existence to unauthorized callers #52151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions scim/core/src/main/java/org/keycloak/scim/resource/spi/BaseResourceTypeProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,12 @@ public R get(String id, List<String> attributes, List<String> excludedAttributes
M model = getModel(id);

if (model == null) {
// Do not leak the existence of a resource to callers without view permission:
// a missing resource must be reported as forbidden (403), not as not found (404),
// otherwise callers can probe which resource ids exist.
if (!canQuery()) {
throw new ForbiddenException();
}
Comment thread
pedroigor marked this conversation as resolved.
Resolved
Comment on lines +59 to +61
@shawkins shawkins Sep 2, 2026
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also discussed here #52304 (comment)

return null;
}
Comment thread
pedroigor marked this conversation as resolved.
Resolved

Expand Down
27 changes: 27 additions & 0 deletions scim/tests/base/src/test/java/org/keycloak/tests/scim/tck/AuthorizationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,33 @@ public void testUsersAccessDeniedIfRolesNotGranted() {
assertAccessDenied(() -> noAccessClient.users().delete(managedUser.getId()));
}

@Test
public void testMissingResourceDoesNotLeakExistence() {
String missingId = KeycloakModelUtils.generateId();
User user = new User();
user.setId(missingId);
user.setUserName("missing");
// A caller without any access must receive 403 (not 404) even for a missing
// resource, so the response code cannot be used to probe whether a given
// resource id exists.
assertAccessDenied(() -> noAccessClient.users().get(missingId));
assertAccessDenied(() -> noAccessClient.users().update(missingId, user));
assertAccessDenied(() -> noAccessClient.users().patch(missingId, PatchRequest.create()
.add("name.displayName", "new display name")
.build()));
assertAccessDenied(() -> noAccessClient.users().delete(missingId));

assertAccessDenied(() -> noAccessClient.groups().get(missingId));
Group resource = new Group();
resource.setId(missingId);
resource.setDisplayName("display name");
assertAccessDenied(() -> noAccessClient.groups().update(missingId, resource));
assertAccessDenied(() -> noAccessClient.groups().patch(missingId, PatchRequest.create()
.add("displayName", "new display name")
.build()));
assertAccessDenied(() -> noAccessClient.groups().delete(missingId));
}

@Test
public void testUsersCanQueryIfQueryRoleGranted() {
grantAdminRole(AdminRoles.QUERY_USERS);
Expand Down
Loading
0