8000 Stabilize flaky test PasskeysUsernameFormTest by ahus1 · Pull Request #52077 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Stabilize flaky test PasskeysUsernameFormTest #52077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahus1 merged 1 commit into from
Aug 27, 2026
Merged

Stabilize flaky test PasskeysUsernameFormTest #52077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Unified Diff View
Unified
2 changes: 1 addition & 1 deletion test-framework/ui/src/main/java/org/keycloak/testframework/ui/page/LoginPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public void fillPassword(String password) {
}

public void submit() {
submitButton.click();
driver.waiting().waitForPageReload(() -> submitButton.click());
}

public void clickSocial(String alias) {
Expand Down
2 changes: 1 addition & 1 deletion test-framework/ui/src/main/java/org/keycloak/testframework/ui/page/LoginUsernamePage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public String getUsernameInputError() {
}

public void submit() {
submitButton.click();
driver.waiting().waitForPageReload(() -> submitButton.click());
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion test-framework/ui/src/main/java/org/keycloak/testframework/ui/page/PasswordPage.java
View file
Open in desktop
8000
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public void fillPassword(String password) {
}

public void submit() {
submitButton.click();
driver.waiting().waitForPageReload(() -> submitButton.click());
}

public String getPassword() {
Expand Down
10 changes: 10 additions & 0 deletions test-framework/ui/src/main/java/org/keycloak/testframework/ui/webdriver/WaitUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,12 @@
import org.keycloak.testframework.ui.page.AbstractPage;

import org.junit.jupiter.api.Assertions;
import org.openqa.selenium.By;
import org.openqa.selenium.StaleElementReferenceException;
import org.openqa.selenium.TimeoutException;
import org.openqa.selenium.WebDriver;
import org.openqa.selenium.WebElement;
import org.openqa.selenium.support.ui.ExpectedConditions;
import org.openqa.selenium.support.ui.WebDriverWait;

public class WaitUtils {
Expand Down Expand Up @@ -58,6 +61,13 @@ public WaitUtils waitForTitle(String title) {
return this;
}

public WaitUtils waitForPageReload(Runnable action) {
WebElement body = managed.findElement(By.tagName("body"));
action.run();
createDefaultWait().until(ExpectedConditions.stalenessOf(body));
return this;
}

public <V> V until(Function<WebDriver, V> isTrue) {
return createDefaultWait().until(isTrue);
}
Expand Down
Loading
0