Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates ConditionalCredentialAuthenticatorTest from Arquillian to the new test framework.
Changes:
- Reworks realm, OAuth, events, and UI test setup.
- Adds OTP page objects and WebDriver support.
- Extends
RealmBuilderwith OTP configuration methods.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
LoginTotpPage.java (legacy) |
Removes migrated helpers. |
ConditionalCredentialAuthenticatorTest.java |
Migrates the integration test. |
ManagedWebDriver.java |
Adds multi-element lookup. |
OneTimeCode.java |
Adds an OTP page object. |
LoginTotpPage.java (framework) |
Adds the framework TOTP page object. |
RealmBuilder.java |
Adds OTP policy setters. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vaceksimon
force-pushed
the
52070-ConditionalCredentialAuthenticatorTest
branch
2 times, most recently
from
August 26, 2026 11:46
3dbd213 to
20e7825
Compare
Contributor
Author
|
Current WebAuthn failure related to: |
vaceksimon
force-pushed
the
52070-ConditionalCredentialAuthenticatorTest
branch
from
September 23, 2026 11:47
20e7825 to
04b097e
Compare
rmartinc
requested changes
Sep 23, 2026
Contributor
There was a problem hiding this comment.
Thanks @vaceksimon! LGTM! Just a nit-pick to not delete and create the realm in each method. Do the logout or move the lifecycle=Method to the user.
Closes: keycloak#52070 Signed-off-by: Simon Vacek <vaceksimon-github@pm.me>
Signed-off-by: Simon Vacek <vaceksimon-github@pm.me>
vaceksimon
force-pushed
the
52070-ConditionalCredentialAuthenticatorTest
branch
from
September 29, 2026 12:33
04b097e to
60fd616
Compare
Contributor
Author
|
Hey @rmartinc, I implemented the suggestion |
rmartinc
approved these changes
Sep 30, 2026
Contributor
There was a problem hiding this comment.
Thanks for the changes @vaceksimon!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #52070