Repository navigation
Client baseUrl URI-scheme validation missing during realm and partial… - #51725
Merged
Merged
Conversation
… import closes keycloak#50123 Signed-off-by: mposolda <mposolda@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds client validation to partial imports, closing the remaining URI-scheme validation bypass.
Changes:
- Validates fully imported clients before committing.
- Returns HTTP 400 and rolls back invalid imports.
- Adds integration coverage for a malicious
javascript:base URL.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
services/src/main/java/org/keycloak/partialimport/ClientsPartialImport.java |
Validates clients during partial import. |
tests/base/src/test/java/org/keycloak/tests/admin/partialimport/PartialImportClientTest.java |
Verifies rejection and rollback of an invalid client. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lhanusov
approved these changes
Aug 14, 2026
Contributor
Author
|
@lhanusov Thanks! |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… import
closes #50123
During full realm import OR during single client import, the client urls were already validated. The only missing "path" was the partial import, which is fixed in this PR