8000 [CVE-2026-8830] Missing server-side WebAuthn validations during credential registration by mabartos · Pull Request #49344 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

[CVE-2026-8830] Missing server-side WebAuthn validations during credential registration - #49344

Merged
rmartinc merged 1 commit into
keycloak:mainfrom
mabartos:webauthn-policies
May 29, 2026
Merged

rmartinc merged 1 commit into
keycloak:mainfrom
mabartos:webauthn-policies

Conversation

@mabartos
Copy link
Copy Markdown
Member

@mabartos mabartos self-assigned this May 26, 2026
@mabartos
mabartos marked this pull request as ready for review May 27, 2026 13:54
@mabartos
mabartos requested review from a team as code owners May 27, 2026 13:54
@mabartos
mabartos marked this pull request as draft May 27, 2026 13:55
@mabartos
mabartos marked this pull request as ready for review May 27, 2026 13:55
@mabartos

This comment was marked as resolved.

@mabartos mabartos added the status/hold PR should not be merged. On hold for later. label May 27, 2026
@mabartos
mabartos force-pushed the webauthn-policies branch from 0d470d4 to 03e50b1 Compare May 28, 2026 07:29
@mabartos
mabartos requested review from a team as code owners May 28, 2026 07:29
@mabartos mabartos removed the status/hold PR should not be merged. On hold for later. label May 28, 2026
@mabartos
mabartos force-pushed the webauthn-policies branch 2 times, most recently from b2333e2 to 57be904 Compare May 28, 2026 10:08
…ntial registration

Closes keycloak#49133

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@mabartos
mabartos force-pushed the webauthn-policies branch from 57be904 to e1b6a3a Compare May 28, 2026 12:28
@mabartos
mabartos requested a review from rmartinc May 28, 2026 14:05
@rmartinc rmartinc left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mabartos! Interesting way of doing the tests. 😄
For what I see the PR adds checks for the signature algorithms and the authenticator (which is best effort). So maybe this is even low risk. But nice to have it.

Check how difficult is back-porting this to 26.4, and if you see it's complicated (don't know because the test or similar, I don't remember what it's the status of the tests in 26.4) feel free to only backport it to 26.6 and remove the label for 26.4.

@rmartinc
rmartinc merged commit 47b9aef into keycloak:main May 29, 2026
87 checks passed
rmartinc pushed a commit that referenced this pull request May 29, 2026
…ntial registration (#49344) (#49479)

Closes #49133


(cherry picked from commit 47b9aef)

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
rmartinc pushed a commit that referenced this pull request May 29, 2026
…ntial registration (#49344) (#49478)

Closes #49133


(cherry picked from commit 47b9aef)

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@stianst stianst mentioned this pull request Jun 1, 2026
sashyo pushed a commit to tide-foundation/keycloak-IGA that referenced this pull request Jul 20, 2026
…ntial registration (keycloak#49344)

Closes keycloak#49133

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CVE-2026-8830] Missing server-side WebAuthn validations during credential registration

3 participants

0