Repository navigation
Add form revert logic for tab providers - #49331
Merged
Merged
Conversation
rmartinc
reviewed
May 27, 2026
Contributor
There was a problem hiding this comment.
Thanks @uzmamansoor09! LGTM, just check if you need the data-testid attribute in the cancel/revert buttons for the follow-up test in the quickstarts. If you need the attribute you can add it before here.
uzmamansoor09
marked this pull request as ready for review
May 27, 2026 09:43
uzmamansoor09
force-pushed
the
47432
branch
3 times, most recently
from
May 27, 2026 10:34
734d156 to
d5d1108
Compare
…tab extension Signed-off-by: uzmamansoor09 <Uzma.Mansoor@ibm.com>
Signed-off-by: uzmamansoor09 <Uzma.Mansoor@ibm.com>
rmartinc
approved these changes
May 28, 2026
Contributor
There was a problem hiding this comment.
Thanks @uzmamansoor09! LGTM!
Closed
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
* Closes keycloak#47432. Reset form on cancel button click in admin ui tab extension Signed-off-by: uzmamansoor09 <Uzma.Mansoor@ibm.com> * Following up review Signed-off-by: uzmamansoor09 <Uzma.Mansoor@ibm.com> --------- Signed-off-by: uzmamansoor09 <Uzma.Mansoor@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47432.
Fixes an issue in the admin UI custom tab extension where clicking the cancel button triggers an incorrect redirection.
PAGE_PROVIDER, the "Cancel" button (which redirects the user) is displayed.TAB_PROVIDER, a "Revert" button is displayed instead, which resets the form state without redirecting.