Repository navigation
fix quick theme export to contain variables for both modes (#49125) - #49322
Merged
Merged
Conversation
…ode (keycloak#49125) Signed-off-by: bu6n <b@u6n.ch>
edewit
approved these changes
May 26, 2026
edewit
enabled auto-merge (squash)
May 26, 2026 08:44
Member
1 of 2 tasks
Closed
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
…ode (keycloak#49125) (keycloak#49322) Signed-off-by: bu6n <b@u6n.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small fix for issue #49125.
I'm tagging @mabartos since I think you are the main person working on quick theme.
The code should speak for itself. One change I'm not sure is the one in
PatternflyVars.ts. This was causing keys named "undefined" in the resulting theme JSON, but this might be used somewhere else?I have used Claude to help me navigate the code, find the cause and write the fix. I think I understand what's happening here.