Repository navigation
Move the rest of TestingResource methods to a utils-shared helper class (2/2) - #49241
Merged
Conversation
vaceksimon
force-pushed
the
48942-Move-the-rest-of-TestingResource-methods-to-a-utils-shared-helper-class
branch
2 times, most recently
from
May 22, 2026 14:47
d11f301 to
5695c2b
Compare
vaceksimon
marked this pull request as ready for review
May 22, 2026 15:12
lhanusov
suggested changes
May 25, 2026
Contributor
There was a problem hiding this comment.
what is the reason, you are adding prepareGroupsLDAPTest into LDAPHelper and then Roles and similars to particular test classes?
| @@ -78,4 +78,5 @@ public static RunOnServer clear() { | |||
| System.clearProperty(FILE); | |||
| }; | |||
| } | |||
|
|
|||
Contributor
Author
There was a problem hiding this comment.
probably accidently added to the commit. Should I remove it?
Contributor
Author
There was a problem hiding this comment.
fixed in the last commit
| @@ -61,8 +62,8 @@ public void importTestRealms() { | |||
|
|
|||
| // add an LDAP provider with a group mapper | |||
| Map<String, String> cfg = ldapRule.getConfig(); | |||
| testingClient.testing().ldap(TEST_REALM_NAME).createLDAPProvider(cfg, true); | |||
| testingClient.testing().ldap(TEST_REALM_NAME).prepareGroupsLDAPTest(); | |||
| runOnServer.fetchString(LdapHelper.createLDAPProvider(cfg, true)); | |||
Contributor
Author
There was a problem hiding this comment.
No, because createLDAPProvider returns a FetchOnServer functional interface and run accepts RunOnServer.
In other usages of this helper method, the resulting String is used; in this instance, it is ignored.
Contributor
Author
|
vaceksimon
force-pushed
the
48942-Move-the-rest-of-TestingResource-methods-to-a-utils-shared-helper-class
branch
from
May 26, 2026 08:34
5695c2b to
979b442
Compare
…ss (2/2) Closes: keycloak#48942 Signed-off-by: Simon Vacek <simonvacky@email.cz>
Signed-off-by: Simon Vacek <simonvacky@email.cz>
vaceksimon
force-pushed
the
48942-Move-the-rest-of-TestingResource-methods-to-a-utils-shared-helper-class
branch
from
May 26, 2026 13:25
979b442 to
5cd1588
Compare
stianst
approved these changes
May 27, 2026
vaceksimon
deleted the
48942-Move-the-rest-of-TestingResource-methods-to-a-utils-shared-helper-class
branch
May 27, 2026 07:08
Closed
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
…ss (2/2) (keycloak#49241) * Move the rest of TestingResource methods to a utils-shared helper class (2/2) Closes: keycloak#48942 Signed-off-by: Simon Vacek <simonvacky@email.cz> * review fix Signed-off-by: Simon Vacek <simonvacky@email.cz> --------- Signed-off-by: Simon Vacek <simonvacky@email.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #48942