Repository navigation
Conversation
Part of: keycloak#48201 Signed-off-by: Jimmy Chakkalakal <jimmy.chakkalakal@ibm.com>
This reverts commit 32b7025.
There was a problem hiding this comment.
@jimmychakkalakal Thanks! Looks good in general. Added some comments inline. Can you please check those?
I think we will need follow-up issue for delete issued credential and also follow-up issues for similar things like for verifiable-credentials (export/import support, cache, user-storage support). But np to create those after this initial PR is merged.
|
@jimmychakkalakal BTW. (not directly related to this PR) It may be better to use Just the info for your future PRs (you can update this PR if you want as well and squash to single commit if you prefer, but not a blocker...) |
There was a problem hiding this comment.
@jimmychakkalakal thanks! I agree with @mposolda's review, I just added one additional comment.
- Add database schema for tracking issued verifiable credentials - Implement admin REST API endpoints for managing issued credentials - Add support for credential revocation tracking - Include tests for new functionality Fixes keycloak#46204 Signed-off-by: Jimmy Chakkalakal <jimmy.chakkalakal@ibm.com>
beb97af to
eba0ef3
Compare
There was a problem hiding this comment.
@jimmychakkalakal @graziang Thanks for the PR and review! Can you please rebase on latest main? I think that should fix the test failure in the UI tests.
|
@jimmychakkalakal I've tried to merge remotely your branch with latest main (remote rebase would be better, but it is not possible due the merge commits in the PR). So maybe that helps with test failures. Nothing else needed for now. I will let you know if something more needed for this PR. |
closes keycloak#46204 Signed-off-by: Jimmy Chakkalakal <jimmy.chakkalakal@ibm.com> Co-authored-by: Marek Posolda <mposolda@gmail.com>
feat(oid4vci): add issued VC tracking and admin REST endpoint
Closes #46204