8000 task: removing the approval test workaround by shawkins · Pull Request #49071 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

task: removing the approval test workaround - #49071

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
shawkins:iss48976
May 19, 2026
Merged

vmuzikar merged 1 commit into
keycloak:mainfrom
shawkins:iss48976

Conversation

@shawkins
Copy link
Copy Markdown
Contributor

closes: #48976

closes: keycloak#48976

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@shawkins
shawkins requested review from Pepo48 and michalvavrik May 18, 2026 17:04
@michalvavrik michalvavrik left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not going to test it in IntelliJ IDEA as I have bad experience with running tests from IDE, but I think this is fine based on https://github.com/approvals/ApprovalTests.Java/releases/tag/30.1.1.

@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@vmuzikar
vmuzikar merged commit 2f6befa into keycloak:main May 19, 2026
91 checks passed
@stianst stianst mentioned this pull request Jun 1, 2026
sashyo pushed a commit to tide-foundation/keycloak-IGA that referenced this pull request Jul 20, 2026
closes: keycloak#48976

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove approvaltest workaround

4 participants

0