8000 fix: prevent service account name from being set in multi-namespace mode by shawkins · Pull Request #49036 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

fix: prevent service account name from being set in multi-namespace mode - #49036

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
shawkins:iss48382
May 22, 2026
Merged

fix: prevent service account name from being set in multi-namespace mode#49036
vmuzikar merged 1 commit into
keycloak:mainfrom
shawkins:iss48382

Conversation

@shawkins
@shawkins shawkins commented May 16, 2026
Copy link
Copy Markdown
Contributor

closes: #48382

@shawkins
fix: prevent service account name from being set in multi-namespace mode
49de3ce 
closes: keycloak#48382

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@shawkins
shawkins requested review from a team as code owners May 16, 2026 16:23
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed May 16, 2026
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented May 16, 2026
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.MultipleTabsLoginTest#testWithAuthSessionExpiredInTheMiddle_badRedirectUri

Keycloak CI - Forms IT (chrome)

org.opentest4j.AssertionFailedError: Expected ErrorPage but was localhost (https://localhost:8543/auth/realms/test/login-actions/authenticate?execution=36683f3e-daa8-4562-b03b-8f487cdd28d2&client_id=test-app&tab_id=8s7CLfjx5Cw&client_data=eyJydSI6Imh0dHBzOi8vbG9jYWxob3N0Ojg1NDMvYXV0aC9yZWFsbXMvbWFzdGVyL2FwcC9hdXRoIiwicnQiOiJjb2RlIn0) ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
...

Report flaky test

@shawkins
shawkins requested review from michalvavrik and vmuzikar May 18, 2026 17:05
michalvavrik
michalvavrik approved these changes May 19, 2026
View reviewed changes
@michalvavrik michalvavrik left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only think of nitpicks. Changes make sense to me.

@shawkins
shawkins requested a review from Pepo48 May 21, 2026 12:22
Pepo48
Pepo48 approved these changes May 22, 2026
View reviewed changes
@Pepo48 Pepo48 left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Thanks Steve!

vmuzikar
vmuzikar approved these changes May 22, 2026
View reviewed changes
@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@vmuzikar
vmuzikar merged commit 2ffb8b6 into keycloak:main May 22, 2026
87 checks passed
@stianst stianst mentioned this pull request Jun 1, 2026
Closed
sashyo pushed a commit to tide-foundation/keycloak-IGA that referenced this pull request Jul 20, 2026
@shawkins @sashyo
fix: prevent service account name from being set in multi-namespace m…
21c0aa5 
…ode (keycloak#49036)

closes: keycloak#48382

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pepo48 Pepo48 Pepo48 approved these changes
@vmuzikar vmuzikar vmuzikar approved these changes
+2 more reviewers
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@michalvavrik michalvavrik michalvavrik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prevent the unsupported pod template from specifying the service account in cluster wide mode

4 participants

@shawkins @Pepo48 @vmuzikar @michalvavrik
0