Repository navigation
Show OpenTelemetry Metrics feature in community build, but allow downstream projects to hide it - #49002
Merged
shawkins merged 1 commit intoMay 15, 2026
Conversation
michalvavrik
force-pushed
the
chore/exclude-micrometer-bridge-from-prod
branch
from
May 14, 2026 16:39
916c5ec to
f103de5
Compare
* Closes: keycloak#48997 Signed-off-by: Michal Vavřík <michal.vavrik@aol.com>
michalvavrik
force-pushed
the
chore/exclude-micrometer-bridge-from-prod
branch
from
May 14, 2026 16:48
f103de5 to
23bb077
Compare
Member
Author
|
Failures are not related, if someone from reviewers can just trigger rerun of failed tests that would be appreciated. I think pushing just to trigger full build is like rolling dice. |
shawkins
approved these changes
May 15, 2026
Contributor
There was a problem hiding this comment.
LGTM. Thanks @michalvavrik
I'll wait for a review from @vmuzikar or @mabartos before merging.
mabartos
approved these changes
May 15, 2026
| OPENTELEMETRY("OpenTelemetry support", Type.DEFAULT), | ||
| OPENTELEMETRY_LOGS("OpenTelemetry Logs support", Type.PREVIEW, OPENTELEMETRY), | ||
| OPENTELEMETRY_METRICS("Micrometer to OpenTelemetry bridge support for metrics", Type.EXPERIMENTAL, OPENTELEMETRY), | ||
| OPENTELEMETRY_METRICS("Micrometer to OpenTelemetry bridge support for metrics", Type.EXPERIMENTAL, 1, false, true, |
Member
There was a problem hiding this comment.
Out of scope - These enum constructors are getting to be really fun to manage 😁 We really need some better approach, like the Features SPI.
Contributor
There was a problem hiding this comment.
Yep, there should at least be a state builder or something.
michalvavrik
added a commit
to michalvavrik/keycloak
that referenced
this pull request
May 15, 2026
…9002) * Closes: keycloak#48997 Signed-off-by: Michal Vavřík <michal.vavrik@aol.com> (cherry picked from commit fc667a8) Signed-off-by: Michal Vavřík <michal.vavrik@aol.com>
vmuzikar
added a commit
that referenced
this pull request
May 19, 2026
Closed
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
…9002) * Closes: keycloak#48997 Signed-off-by: Michal Vavřík <michal.vavrik@aol.com>
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
…ycloak#49002)" (keycloak#49072) This reverts commit fc667a8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.