Repository navigation
Remove redundant pnpm overrides from JS workspace - #49546
Merged
Merged
Conversation
edewit
force-pushed
the
remove-redundant-pnpm-overrides
branch
2 times, most recently
from
June 1, 2026 11:42
d64e623 to
c26aba9
Compare
Contributor
Author
abstractj
previously approved these changes
Jun 1, 2026
Contributor
There was a problem hiding this comment.
Thank you, LGTM. We only need a rebase.
The pnpm 11 upgrade (keycloak#48975) added security floor overrides for several transitive dependencies. Re-testing shows most of them are no longer needed: pnpm already resolves to patched versions without forcing them. Remove overrides that no longer change resolution: - picomatch@^2, flatted, minimatch@~3, minimatch@~9 - @isaacs/brace-expansion@^5 (unused in the lockfile) - diff@^4 (already resolves to 4.0.4) Keep overrides still required because mocha (dev dep of keycloak-admin-client) would otherwise pull vulnerable versions: - serialize-javascript: ^7.0.5 (mocha requests ^6.0.2) - diff@^7: ^8.0.3 (mocha requests ^7.0.0, CVE fix requires >=8.0.3) Also bump the serialize-javascript floor from ^7.0.3 to ^7.0.5 to match the fully patched advisory range. Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
edewit
force-pushed
the
remove-redundant-pnpm-overrides
branch
from
June 2, 2026 06:26
c26aba9 to
4d715cf
Compare
Contributor
|
@edewit Could you please create and link an issue to this? |
stianst
approved these changes
Jun 11, 2026
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
The pnpm 11 upgrade (keycloak#48975) added security floor overrides for several transitive dependencies. Re-testing shows most of them are no longer needed: pnpm already resolves to patched versions without forcing them. Remove overrides that no longer change resolution: - picomatch@^2, flatted, minimatch@~3, minimatch@~9 - @isaacs/brace-expansion@^5 (unused in the lockfile) - diff@^4 (already resolves to 4.0.4) Keep overrides still required because mocha (dev dep of keycloak-admin-client) would otherwise pull vulnerable versions: - serialize-javascript: ^7.0.5 (mocha requests ^6.0.2) - diff@^7: ^8.0.3 (mocha requests ^7.0.0, CVE fix requires >=8.0.3) Also bump the serialize-javascript floor from ^7.0.3 to ^7.0.5 to match the fully patched advisory range. Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
picomatch@^2,flatted,minimatch@~3,minimatch@~9,@isaacs/brace-expansion@^5, anddiff@^4.mochatransitive dependencies inkeycloak-admin-client:serialize-javascriptanddiff@^7.serialize-javascriptoverride floor from^7.0.3to^7.0.5to match the fully patched advisory range.Rationale
These overrides were added during the pnpm 11 upgrade (#48975) as security floors. Re-testing shows the removed ones are redundant today — pnpm already resolves to patched versions without them. Removing them reduces lockfile churn and review noise on future installs.