8000 [OID4VCI]: Migrate OID4VCSdJwtIssuingEndpointTest test to new framework by Awambeng · Pull Request #49419 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

[OID4VCI]: Migrate OID4VCSdJwtIssuingEndpointTest test to new framework - #49419

Merged
mposolda merged 2 commits into
keycloak:mainfrom
adorsys:issue-49411
May 28, 2026
Merged

[OID4VCI]: Migrate OID4VCSdJwtIssuingEndpointTest test to new framework#49419
mposolda merged 2 commits into
keycloak:mainfrom
adorsys:issue-49411

Conversation

@Awambeng
@Awambeng Awambeng commented May 28, 2026
Copy link
Copy Markdown
Contributor

Closes #49411

@Awambeng
Awambeng requested review from a team as code owners May 28, 2026 12:01
@Awambeng Awambeng mentioned this pull request May 28, 2026
Closed
1 task done
@mposolda mposolda self-assigned this May 28, 2026
mposolda
mposolda reviewed May 28, 2026
View reviewed changes
@mposolda mposolda left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Awambeng The regression in FIPS tests is likely caused by changes in your PR. I think you may need to remove the test from the old testsuite from the file testsuite/integration-arquillian/tests/base/testsuites/fips-suite and add it instead in the new testsuite to the files FipsNonStrictTestSuite and FipsStrictTestSuite

@Awambeng
Awambeng commented May 28, 2026
Copy link
Copy Markdown
Contributor Author

@Awambeng The regression in FIPS tests is likely caused by changes in your PR. I think you may need to remove the test from the old testsuite from the file testsuite/integration-arquillian/tests/base/testsuites/fips-suite and add it instead in the new testsuite to the files FipsNonStrictTestSuite and FipsStrictTestSuite

Thanks @mposolda, you’re right. I’ll update the testsuites accordingly.

Awambeng added 2 commits May 28, 2026 15:21
@Awambeng
feat: migrate OID4VCSdJwtIssuingEndpointTest test to new framework
4ab133b 
Closes keycloak#49411

Signed-off-by: Awambeng Rodrick <awambengrodrick@gmail.com>
@Awambeng
test: migrate OID4VCSdJwtIssuingEndpointTest from Arquillian to JUnit…
3d48731 
… 5 FIPS test suites

Signed-off-by: Awambeng Rodrick <awambengrodrick@gmail.com>
@Awambeng
Awambeng requested a review from mposolda May 28, 2026 15:16
mposolda
mposolda approved these changes May 28, 2026
View reviewed changes
@mposolda mposolda left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Awambeng Thanks!

@mposolda
mposolda merged commit 1ae46fc into keycloak:main May 28, 2026
87 checks passed
@Awambeng
Awambeng deleted the issue-49411 branch May 28, 2026 15:40
@stianst stianst mentioned this pull request Jun 1, 2026
Closed
sashyo pushed a commit to tide-foundation/keycloak-IGA that referenced this pull request Jul 20, 2026
@Awambeng @sashyo
[OID4VCI]: Migrate OID4VCSdJwtIssuingEndpointTest test to new framewo…
a17f317 
…rk (keycloak#49419)

Closes keycloak#49411


Signed-off-by: Awambeng Rodrick <awambengrodrick@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes

Assignees

@mposolda mposolda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate OID4VCSdJwtIssuingEndpointTest to the new testsuite

2 participants

@Awambeng @mposolda
0