8000 Upgrade to Quarkus 3.33.2 by vmuzikar · Pull Request #49401 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Upgrade to Quarkus 3.33.2 - #49401

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
vmuzikar:quarkus-3.33.2
May 28, 2026
Merged

vmuzikar merged 1 commit into
keycloak:mainfrom
vmuzikar:quarkus-3.33.2

Conversation

@vmuzikar
Copy link
Copy Markdown
Contributor

Closes #48311
Closes #46172
Closes #48805

Closes keycloak#48311
Closes keycloak#46172
Closes keycloak#48805

Signed-off-by: Václav Muzikář <vmuzikar@ibm.com>
@vmuzikar
vmuzikar requested a review from a team as a code owner May 28, 2026 08:07
@vmuzikar
Copy link
Copy Markdown
Contributor Author

Quarkus still uses Postgres 42.7.10, so we need to keep the override in place.

Comment thread pom.xml
<hibernate-orm.plugin.version>6.2.13.Final</hibernate-orm.plugin.version>
<hibernate.c3p0.version>6.2.13.Final</hibernate.c3p0.version>
<microprofile-metrics-api.version>5.1.2</microprofile-metrics-api.version>
<infinispan.version>16.0.8</infinispan.version>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quarkus is using https://github.com/quarkusio/quarkus/blob/3.33.2/bom/application/pom.xml#L131 16.0.9. Should we stick to 16.0.8?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not aligning Infinispan version with Quarkus. Maybe @ahus1 remembers the reasoning behind that.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks. Maybe there could be a comment added in the future, because it seems random to me.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the infinispan version, even micro ones, could be a little involved: https://github.com/keycloak/keycloak/pull/47018/changes cc @ryanemerson

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the infinispan version, even micro ones, could be a little involved: https://github.com/keycloak/keycloak/pull/47018/changes cc @ryanemerson

in general, I think the same can be said about each of our component, e.g. following bumps were not involved:

I agree it makes sense to leave this to experts, so I withdraw my question. Thanks

@ryanemerson ryanemerson May 28, 2026 •
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't align with the Quarkus Infinispan version as we need to use the Infinispan version that is used downstream for Data Grid as this is a dependency for our HA multi-cluster capabilities with RHBK. #49206 has been created to track the next upgrade.

Ok, thanks. Maybe there could be a comment added in the future, because it seems random to me.

That could help 👍

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't align with the Quarkus Infinispan version as we need to use the Infinispan version that is used downstream for Data Grid as this is a dependency for our HA multi-cluster capabilities with RHBK. #49206 has been created to track the next upgrade.

I see. I'm still learning, thanks.

@michalvavrik michalvavrik left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmuzikar
vmuzikar requested a review from shawkins May 28, 2026 13:08
@vmuzikar
vmuzikar enabled auto-merge (squash) May 28, 2026 13:09
@vmuzikar
Copy link
Copy Markdown
Contributor Author

@shawkins Can I get your green tick, so we can merge? :)

@shawkins shawkins left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmuzikar
vmuzikar merged commit 4988980 into keycloak:main May 28, 2026
147 of 149 checks passed
@vmuzikar
vmuzikar deleted the quarkus-3.33.2 branch May 28, 2026 17:43
@stianst stianst mentioned this pull request Jun 1, 2026
sashyo pushed a commit to tide-foundation/keycloak-IGA that referenced this pull request Jul 20, 2026
Closes keycloak#48311
Closes keycloak#46172
Closes keycloak#48805

Signed-off-by: Václav Muzikář <vmuzikar@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

4 participants

0