8000 [OID4VCI-FAPI2] Pass fapi2-security-profile-final-state-only-outside-request-object-not-used (blocked) by tdiesler · Pull Request #48326 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

[OID4VCI-FAPI2] Pass fapi2-security-profile-final-state-only-outside-request-object-not-used (blocked) - #48326

Closed
tdiesler wants to merge 3 commits into
keycloak:mainfrom
tdiesler:ghi48047
Closed

[OID4VCI-FAPI2] Pass fapi2-security-profile-final-state-only-outside-request-object-not-used (blocked)#48326
tdiesler wants to merge 3 commits into
keycloak:mainfrom
tdiesler:ghi48047

Conversation

@tdiesler
@tdiesler tdiesler commented Apr 21, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor

@tdiesler
tdiesler requested a review from a team as a code owner April 21, 2026 14:09
@tdiesler
tdiesler force-pushed the ghi48047 branch 3 times, most recently from dc687d8 to 4395d10 Compare April 21, 2026 14:22
@tdiesler
tdiesler requested review from a team as code owners April 21, 2026 14:22
@tdiesler
tdiesler force-pushed the ghi48047 branch 3 times, most recently from 98ad67f to 25da467 Compare April 21, 2026 15:30
@tdiesler
tdiesler marked this pull request as draft April 21, 2026 16:49
@tdiesler
tdiesler marked this pull request as ready for review April 21, 2026 19:05
@tdiesler
tdiesler force-pushed the ghi48047 branch 2 times, most recently from 185eb89 to 6714f1b Compare April 21, 2026 19:16
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Apr 21, 2026
Closed
@tdiesler
tdiesler marked this pull request as draft April 22, 2026 01:00
@tdiesler
tdiesler force-pushed the ghi48047 branch 4 times, most recently from 30e362b to b3f3fc6 Compare April 22, 2026 15:06
This was referenced Apr 29, 2026
Closed
Closed
@tdiesler
tdiesler force-pushed the ghi48047 branch 3 times, most recently from 307ae77 to aa481af Compare April 30, 2026 06:17
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Apr 30, 2026
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Apr 30, 2026
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.passwordless.PasskeysOrganizationAuthenticationTest#webauthnLoginWithDiscoverableKeyRequiresMembership

Keycloak CI - WebAuthn IT

org.opentest4j.AssertionFailedError: Expected InfoPage but was localhost (https://localhost:8543/auth/realms/test/protocol/openid-connect/logout/logout-confirm?client_id=account&tab_id=-fJ6KcJMGDA) ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
...

Report flaky test

@tdiesler
tdiesler force-pushed the ghi48047 branch 3 times, most recently from b5c44f3 to b7f7bfe Compare April 30, 2026 10:22
@tdiesler tdiesler changed the title [OID4VCI-FAPI2] Pass fapi2-security-profile-final-state-only-outside-request-object-not-used [OID4VCI-FAPI2] Pass fapi2-security-profile-final-state-only-outside-request-object-not-used (blocked) Apr 30, 2026
@tdiesler
tdiesler force-pushed the ghi48047 branch 2 times, most recently from 0b47aa3 to 0e92c3a Compare May 5, 2026 15:30
@tdiesler
tdiesler marked this pull request as ready for review May 5, 2026 15:35
@tdiesler tdiesler mentioned this pull request May 6, 2026
Closed
@tdiesler
tdiesler force-pushed the ghi48047 branch 5 times, most recently from dec2007 to 49184d7 Compare May 7, 2026 08:43
This was referenced May 7, 2026
Closed
Closed
@tdiesler
[OAuth] Prefer authorization error on redirect_uri
ca7249e 
Signed-off-by: Thomas Diesler <tdiesler@proton.me>
@tdiesler
tdiesler marked this pull request as draft May 9, 2026 07:36
tdiesler added 2 commits May 12, 2026 10:02
@tdiesler
Merge branch 'ghi48542' into ghi48047
3b4e930 
* ghi48542:
  [OAuth] Prefer authorization error on redirect_uri
@tdiesler
[OID4VCI-FAPI2] Pass fapi2-security-profile-final-state-only-outside-…
e081b3b 
…request-object-not-used

closes keycloak#48047

Signed-off-by: Thomas Diesler <tdiesler@proton.me>
@tdiesler tdiesler closed this May 12, 2026
@tdiesler
tdiesler deleted the ghi48047 branch May 12, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot will automatically review once the pull request is marked ready for review
1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mposolda mposolda

@tnorimat tnorimat

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[OID4VCI-FAPI2] Pass fapi2-security-profile-final-state-only-outside-request-object-not-used

3 participants

@tdiesler @tnorimat @mposolda
0